Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT HLT fix #3450

Closed
wants to merge 214 commits into from
Closed

DT HLT fix #3450

wants to merge 214 commits into from

Conversation

ptraczyk
Copy link
Contributor

Fix the backwards compatibility of DT reco in HLT that was broken in 710pre5. This PR is on top of #3246 (consumes migration of DT code)

ptraczyk and others added 30 commits March 19, 2014 10:19
… factory

- Add new constructors to BaseCkfTrajectoryBuilder classes
- Add BaseCkfTrajectoryBuilderFactory
- Add BaseCkfTrajectoryBuilder::setEvent() (to be called instead of clone)
- Migrate CkfTrackCandidateMakerBase and ConversionTrackCandidateProducer
  to construct BaseCkfTrajectroryBuilder via factory
- In MuonCkfTrajectoryBuilder, the theEtaPhiEstimator must be
  initialised in setEvent_() instead of constructor
- Remove CkfTrajectoryBuilder ESProducers
The old ESProducer files are kept for now for ConfDB migration, they
will be cleaned afterwards.
- Add TrajectoryFilter::setEvent() to read data from edm::Event and/or edm::EventSetup
- Remove TrajectoryFilter ESProducers
- Remove TYPELOOKUP_DATA_REG(TrajectoryFilter)
@cmsbuild
Copy link
Contributor

-1
I found an error when building:

Entering library rule at DQMServices/Core
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/DQMServices/Diagnostic/bin/MakeDeanHTML.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTRecHit/src/DTRecHitBaseAlgo.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTRecHit/src/DTRecHitAlgoFactory.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/EventFilter/DTTFRawToDigi/src/DTTFFEDReader.cc: In constructor 'DTTFFEDReader::DTTFFEDReader(const edm::ParameterSet&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/EventFilter/DTTFRawToDigi/src/DTTFFEDReader.cc:37:50: error: 'getDTTFInputTag' was not declared in this scope
   consumes(getDTTFInputTag());
                                                  ^
Entering library rule at src/RecoLocalMuon/DTRecHit/test
Entering library rule at src/RecoLocalMuon/DTRecHit/plugins
Entering library rule at RecoLocalMuon/DTSegment


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3450/1126/summary.html

@slava77
Copy link
Contributor

slava77 commented Apr 29, 2014

-1

Piotr, please resubmit the physics performance changes separately.
I have submitted just the consumes migration in #3486.
Mostly for technical reasons we need the consumes to go out at the earliest.

@ptraczyk
Copy link
Contributor Author

ok, got it!

On Tue, Apr 29, 2014 at 6:23 AM, Slava Krutelyov
notifications@github.comwrote:

-1

Piotr, please resubmit the physics performance changes separately.
I have submitted just the consumes migration in #3486#3486
.
Mostly for technical reasons we need the consumes to go out at the
earliest.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3450#issuecomment-41640558
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet