Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_getPayloadData in case there've been recent changes in the plugins definitions #34515

Merged
merged 1 commit into from Jul 18, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 16, 2021

fixes #34512

PR description:

Addresses #34512 (comment) by not looking for a specific key in the returned json file, but just checking if the length is not 0.

PR validation:

scram b runtests 

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Jul 16, 2021
@mmusich mmusich changed the title fix test_getPayloadData in case there've been recent changes in the plugins definitions fix test_getPayloadData in case there've been recent changes in the plugins definitions Jul 16, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34515/24014

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/Utilities (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 16, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edc7c2/16895/summary.html
COMMIT: b255057
CMSSW: CMSSW_12_0_X_2021-07-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34515/16895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786279
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jul 16, 2021

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Jul 16, 2021

urgent

@qliphy
Copy link
Contributor

qliphy commented Jul 18, 2021

ping @cms-sw/db-l2

@ggovi
Copy link
Contributor

ggovi commented Jul 18, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 33664ef into cms-sw:master Jul 18, 2021
@mmusich mmusich deleted the moreFixesGetPayloadData branch July 18, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testGetPayloadData (getPayloadData.py) unit failure
5 participants