-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable general gamma process for Geant4 #34564
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34564/24101
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d5caa/17021/summary.html Comparison SummarySummary:
|
+1 General gamma process uses different number of calls to the random number generator, so no regression is expected. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
For the record: There is an on-going check on size change from this PR in cms-sw/cms-bot#1595 |
@qliphy , @slava77, on SIM step there should be some increase of memory due to extra data tables built at initialisation. From the report I do not understand is this value is significant or not, also do not understand if there is any effect of RECO. At least, at my tests, which are not very accurate I do not see a significant overhead. |
+1 |
PR description:
General gamma process is a new method for gamma transport available with Geant4 10.7. For Run-3 CMS this bring ~1% CPU advantage with statistically same results. For Phase-2 the speed-up should be more.
PR validation:
private