[DQM] esConsumes migration for Validation package leftovers

[jfernan2]

PR description:

Following comment on #31061 (comment) and tips by @makortel (thanks a lot!!) the leftovers from Validation/* packages in what esConsumes migration refers, are being fixed in this PR

Modules from DQM/Ecal are being migrated by ECAL DPG @abhih1

PR validation:

Code compiles and tested with:
runTheMatrix.py -l limited -i all --ibeos -t 9

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34604/24168

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34604/24168/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34604/24168/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

hold

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34604/24169

• This PR adds an extra 60KB to repository

[cmsbuild]

Pull request has been put on hold by @jfernan2
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• CommonTools/RecoAlgos (reconstruction)
• DQM/Physics (dqm)
• SimTracker/TrackHistory (simulation)

@perrotta, @civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@JanFSchulte, @rappoccio, @jdolen, @makortel, @mtosi, @abbiendi, @GiacomoSguazzoni, @emilbols, @rovere, @VinInn, @mmusich, @JyothsnaKomaragiri, @gkasieczka, @jhgoh, @hatakeyamak, @ahinzmann, @andrzejnovak, @threus, @dgulhan, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34604/24281

• This PR adds an extra 120KB to repository

[cmsbuild]

Pull request #34604 was updated. @perrotta, @civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @jfernan2, @ahmad3213, @slava77, @jpata, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab2230/17288/summary.html
COMMIT: 16b1bf0
CMSSW: CMSSW_12_0_X_2021-07-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34604/17288/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 628
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2997914
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Changes in Top Physics folder due to different way of setting Jet corrections. To be reviewed by TOP DQM contacts

[civanch]

+1

[jpata]

+reconstruction

• technical, reco review limited to CommonTools/RecoAlgos
• no reco changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Technical, no changes in outputs