Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GT string for 12_0_X #34613

Merged
merged 4 commits into from Jul 28, 2021
Merged

Update GT string for 12_0_X #34613

merged 4 commits into from Jul 28, 2021

Conversation

@chayanit
Copy link
Author

please test

There are a few missing GENSIMs and I just wanna check if I have covered all of them.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34613/24186

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b93692/17167/summary.html
COMMIT: b15f6f6
CMSSW: CMSSW_12_0_X_2021-07-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34613/17167/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

@perrotta
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34613/24190

  • This PR adds an extra 48KB to repository

@qliphy
Copy link
Contributor

qliphy commented Jul 28, 2021

Hello @qliphy , @silviodonato , could you remind me how it should work for new datasets just produced? I think the RelVal inputs are stored at FNAL and bot complained error because not being able to find it at CERN.

@chayanit You may check here: #33090 (comment)

@chayanit
Copy link
Author

please test

try again if the queries are ready for bot this round

@qliphy
Copy link
Contributor

qliphy commented Jul 28, 2021

please abort

@qliphy
Copy link
Contributor

qliphy commented Jul 28, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b93692/17289/summary.html
COMMIT: f875df9
CMSSW: CMSSW_12_0_X_2021-07-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34613/17289/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6858 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 56327
  • DQMHistoTests: Total nulls: 62
  • DQMHistoTests: Total successes: 2942153
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.954 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.954 KiB SiStrip/MechanicalView
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 2 / 38 workflows

@qliphy
Copy link
Contributor

qliphy commented Jul 28, 2021

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 The tests are done. Please have a look. If possible, we can try to include this for pre5.

@bbilin
Copy link
Contributor

bbilin commented Jul 28, 2021

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 28, 2021

+1

@cmsbuild cmsbuild merged commit a746a5b into cms-sw:master Jul 28, 2021
SissonJ pushed a commit to SissonJ/cmssw that referenced this pull request Aug 23, 2021
Creating a new step for RunCosmics2021 with run number 343498 and dataset /ExpressCosmics/Commissioning2021-Express-v1/FEVT

Follow up of the PR cms-sw#34613.
lwezenbe pushed a commit to lwezenbe/cmssw that referenced this pull request Oct 11, 2021
Creating a new step for RunCosmics2021 with run number 343498 and dataset /ExpressCosmics/Commissioning2021-Express-v1/FEVT

Follow up of the PR cms-sw#34613.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants