Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTD geometry: fix scenario I14 for material budget studies #34625

Merged
merged 1 commit into from
Jul 27, 2021
Merged

MTD geometry: fix scenario I14 for material budget studies #34625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Geometry/MTDCommonData/data/etl/v6/etl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
</LogicalPart>
<LogicalPart name="FrontModerator" category="unspecified">
<rSolid name="etl:FrontModerator"/>
<rMaterial name="materials:Borated Polyethyl."/>
<rMaterial name="mtdMaterial:Borated_Polyethyl."/>
</LogicalPart>
<LogicalPart name="Cables" category="unspecified">
<rSolid name="etl:Cables"/>
Expand Down
5 changes: 5 additions & 0 deletions Geometry/MTDCommonData/data/mtdMaterial/v3/mtdMaterial.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,11 @@
<rMaterial name="materials:Air"/>
</MaterialFraction>
</CompositeMaterial>
<CompositeMaterial name="Borated_Polyethyl." density="950*mg/cm3" symbol=" " method="mixture by weight">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this seemingly duplicate material introduced? It has the same density as materials:Borated Polyethyl..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvuosalo this is essentially a workaround to let the material budget validation code parsing without issues the tables with the material names, it is unclear to me how to handle blanks in the middle (it was a bad idea to introduce them in first place, I would say). I mimicked what done already for other similar situations, see for instance

https://cmssdt.cern.ch/lxr/source/Geometry/CMSCommonData/data/materials.xml#1157

If you have a better solution to suggest I will be happy to consider it, I do not like this solution either, but "it just works".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiocos Thanks, I understand now. It is unfortunate that we are stuck with this name containing a space, but I see it is widely used, so it would be some effort to change.

<MaterialFraction fraction="1.00000000">
<rMaterial name="materials:Borated Polyethyl."/>
</MaterialFraction>
</CompositeMaterial>
</MaterialSection>

</DDDefinition>
22 changes: 22 additions & 0 deletions Validation/Geometry/data/mtdMaterials.l0
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,25 @@ ServiceHybrid_PCB 0.000 0.000 0.000 0.000
Aluminium_Nitride 0.000 0.000 0.000 0.000 1.000

ThermalScreenComposite 0.000 0.000 0.000 1.000 0.000

ETLPatchPanel 0.000 0.000 0.000 0.000 1.000

Tin 0.000 0.000 0.000 0.000 1.000

Cables1 0.000 0.000 0.000 0.000 1.000

Cables2 0.000 0.000 0.000 0.000 1.000

Cables3 0.000 0.000 0.000 0.000 1.000

Cables4 0.000 0.000 0.000 0.000 1.000

Cables5 0.000 0.000 0.000 0.000 1.000

Cables6 0.000 0.000 0.000 0.000 1.000

Cables7 0.000 0.000 0.000 0.000 1.000

Carbon_fibre_str_Upgrade 0.000 0.000 0.000 1.000 0.000

Borated_Polyethyl. 0.000 0.000 0.000 1.000 0.000
22 changes: 22 additions & 0 deletions Validation/Geometry/data/mtdMaterials.x0
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,25 @@ ServiceHybrid_PCB 0.000 0.000 0.000 0.000
Aluminium_Nitride 0.000 0.000 0.000 0.000 1.000

ThermalScreenComposite 0.000 0.000 0.000 1.000 0.000

ETLPatchPanel 0.000 0.000 0.000 0.000 1.000

Tin 0.000 0.000 0.000 0.000 1.000

Cables1 0.000 0.000 0.000 0.000 1.000

Cables2 0.000 0.000 0.000 0.000 1.000

Cables3 0.000 0.000 0.000 0.000 1.000

Cables4 0.000 0.000 0.000 0.000 1.000

Cables5 0.000 0.000 0.000 0.000 1.000

Cables6 0.000 0.000 0.000 0.000 1.000

Cables7 0.000 0.000 0.000 0.000 1.000

Carbon_fibre_str_Upgrade 0.000 0.000 0.000 1.000 0.000

Borated_Polyethyl. 0.000 0.000 0.000 1.000 0.000
4 changes: 2 additions & 2 deletions Validation/Geometry/macros/MaterialBudgetMtd.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,15 @@ void createPlots(TString plot) {
abscissaName = TString("#eta");
ordinateName = TString("t/#lambda_{I}");
ymin = 0.0;
ymax = 0.08;
ymax = 0.18;
xmin = -4.0;
xmax = 4.0;
} else if (plot.CompareTo("l_vs_phi") == 0) {
plotNumber = 1020;
abscissaName = TString("#varphi [rad]");
ordinateName = TString("t/#lambda_{I}");
ymin = 0.0;
ymax = 0.08;
ymax = 0.18;
xmin = -3.2;
xmax = 3.2;
} else {
Expand Down