NANO: rework for Prompt (part1) #34661

mariadalfonso · 2021-07-27T22:54:50Z

part1 of the #34329
migrate all the object from Sequence to Task, except the ele,lowPtEle,photon,met,jet
no changes expected in any of the modifiers

mariadalfonso · 2021-07-27T22:59:18Z

please test

cmsbuild · 2021-07-27T23:04:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34661/24272

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/boostedTaus_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/btagWeightTable_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/extraflags_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/genVertex_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/genWeightsTable_cfi.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329, Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/genparticles_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/globals_cff.py modified in PR(s): Storing Generator Filter Information in NanoAOD #34169, DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/isotracks_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/jets_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329, Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329, Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/particlelevel_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/protons_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/taus_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/taus_updatedMVAIds_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/ttbarCategorization_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329
- File PhysicsTools/NanoAOD/python/vertices_cff.py modified in PR(s): DRAFT: nano: adaptation to run in Prompt #34329

cmsbuild · 2021-07-27T23:04:35Z

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-07-28T02:13:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dddd4/17273/summary.html
COMMIT: 5f0fe1f
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34661/17273/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1306 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 3677
DQMHistoTests: Total nulls: 20
DQMHistoTests: Total successes: 2994845
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.699 KiB( 38 files compared)
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 8 / 38 workflows

mariadalfonso · 2021-07-28T08:00:42Z

No significant changes to the logs found

Reco comparison results: 1306 differences found in the comparisons

1299/1306 due to 140.53

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-07-27-1100+3dddd4/44411/validateJR.html
changes in the deepMetResolution and deepMetResponse not clear why this happen.
I had to add 5f0fe1f otherwise crash (despite the changes in ba1a837 is not supposed to change anything in the MET)

I think we merge, open an issue and then JME follow up together with the other multitude of problems of the MET :(

mariadalfonso · 2021-07-28T08:23:57Z

please test workflow 546,547,548

(test nanoGen)

mariadalfonso · 2021-07-28T09:30:14Z

urgent

(ideally should go in the 12_0_pre5)

cmsbuild · 2021-07-28T11:52:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dddd4/17294/summary.html
COMMIT: 5f0fe1f
CMSSW: CMSSW_12_0_X_2021-07-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34661/17294/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3dddd4/546.0_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3dddd4/547.0_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3dddd4/548.0_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998529
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 8 / 38 workflows

mariadalfonso · 2021-07-28T12:00:02Z

+xpog

technical changes
to follow up on separate issue NANO: rework for Prompt (part1) #34661 (comment)

cmsbuild · 2021-07-28T12:00:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-07-28T12:38:25Z

+1

mariadalfonso added 2 commits July 27, 2021 23:35

rework for Prompt: part1

ba1a837

need to comment this (?)

5f0fe1f

cmsbuild added this to the CMSSW_12_0_X milestone Jul 27, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Jul 27, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 27, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2021

cmsbuild added tests-started and removed tests-approved labels Jul 28, 2021

cmsbuild added the urgent label Jul 28, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2021

ramonbrugman approved these changes Jul 28, 2021

View reviewed changes

cmsbuild removed the pending-signatures label Jul 28, 2021

cmsbuild added fully-signed xpog-approved and removed xpog-pending labels Jul 28, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 28, 2021

cmsbuild merged commit f904c81 into cms-sw:master Jul 28, 2021

This was referenced Jul 28, 2021

Update DT DQM, calibration scripts, and local reco code to allow using "new" DB format #34612

Merged

DQM Pixel Phase 1: Several new Efficiency trend plots #34384

Merged

mariadalfonso mentioned this pull request Jul 29, 2021

NANO: rework for Prompt (part2) #34695

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NANO: rework for Prompt (part1) #34661

NANO: rework for Prompt (part1) #34661

mariadalfonso commented Jul 27, 2021 •

edited

mariadalfonso commented Jul 27, 2021

cmsbuild commented Jul 27, 2021

cmsbuild commented Jul 27, 2021

cmsbuild commented Jul 28, 2021

mariadalfonso commented Jul 28, 2021 •

edited

mariadalfonso commented Jul 28, 2021 •

edited

mariadalfonso commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

mariadalfonso commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

qliphy commented Jul 28, 2021

NANO: rework for Prompt (part1) #34661

NANO: rework for Prompt (part1) #34661

Conversation

mariadalfonso commented Jul 27, 2021 • edited

mariadalfonso commented Jul 27, 2021

cmsbuild commented Jul 27, 2021

cmsbuild commented Jul 27, 2021

cmsbuild commented Jul 28, 2021

Comparison Summary

mariadalfonso commented Jul 28, 2021 • edited

mariadalfonso commented Jul 28, 2021 • edited

mariadalfonso commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

Comparison Summary

mariadalfonso commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

qliphy commented Jul 28, 2021

mariadalfonso commented Jul 27, 2021 •

edited

mariadalfonso commented Jul 28, 2021 •

edited

mariadalfonso commented Jul 28, 2021 •

edited