Reserve one bit for the flag in pixel digi packing - bugfix for PR #34509

[tsusa]

PR description:

This PR is a follow up (bugfix) of the PR #34509, which was intended to reserve one bit for flagging individual pixels, but failed to do so.
No changes are expected.

PR validation:

No failure when running runTheMatrix.py

@veszpv, @mmusich, @cms-sw/reconstruction-l2

[tsusa]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34662/24273

• This PR adds an extra 8KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/SiPixelDetId/interface/PixelChannelIdentifier.h modified in PR(s): Pixel cluster repair by morphing #34606

[cmsbuild]

A new Pull Request was created by @tsusa (Tatjana Susa) for master.

It involves the following packages:

• DataFormats/SiPixelDetId (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @VinInn, @OzAmram, @dkotlins, @ferencek, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[tvami]

urgent

[tvami]

Hi @civanch as discussed today at ORP can you please sign this quickly so it can still be included in pre5? Thanks!

[slava77]

@cmsbuild please test

[slava77]

( I forgot during the ORP that this fix is not in the reco category; well, one signature less)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d96896/17274/summary.html
COMMIT: 8cd0049
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34662/17274/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1302 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 3677
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2994845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.699 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[mmusich]

@tsusa can the title be a little bit more specific?

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1