[FWCore][clang-tidy] make deleted function public

[smuzaffar]

We have over 25K clang-tidy warnings about deleted member function should be public [modernize-use-equals-delete]. 9K of these come from FWCore sub-system.
Locally tested, it build and all of the modernize-use-equals-delete warnings are fixed.

[a]

FWCore/Framework/interface/EventSetupImpl.h:86:5: warning: deleted member function should be public [modernize-use-equals-delete]
    EventSetupImpl() = delete;
    ^
FWCore/Framework/interface/one/EDAnalyzer.h:57:7: warning: deleted member function should be public [modernize-use-equals-delete]
      EDAnalyzer(const EDAnalyzer&) = delete;
      ^
FWCore/Framework/interface/one/EDAnalyzer.h:58:25: warning: deleted member function should be public [modernize-use-equals-delete]
      const EDAnalyzer& operator=(const EDAnalyzer&) = delete;

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34667/24284

• This PR adds an extra 88KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• FWCore/FWLite (core)
• FWCore/Framework (core)
• FWCore/MessageLogger (core)
• FWCore/MessageService (core)
• FWCore/Modules (core)
• FWCore/PluginManager (core)
• FWCore/SOA (core)
• FWCore/Services (core)
• FWCore/Sources (core)
• FWCore/Utilities (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34667/24295

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #34667 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ce0b3/17313/summary.html
COMMIT: 6c48442
CMSSW: CMSSW_12_0_X_2021-07-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34667/17313/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[makortel]

+1

The test failed in the reference IB.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Technical, no changes in outputs

[perrotta]

merge