Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CommonTools][clang-tidy] make deleted function public #34669

Merged
merged 1 commit into from Jul 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CommonTools/Utils/interface/TH1AddDirectorySentry.h
Expand Up @@ -26,9 +26,10 @@ class TH1AddDirectorySentry {
TH1AddDirectorySentry();
~TH1AddDirectorySentry();

private:
TH1AddDirectorySentry(const TH1AddDirectorySentry&) = delete;
TH1AddDirectorySentry& operator=(const TH1AddDirectorySentry&) = delete;

private:
bool status_;
};

Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaBinaryOperatorEvaluator.h
Expand Up @@ -84,11 +84,11 @@ namespace reco {
return ret;
}

private:
BinaryOperatorEvaluator(const BinaryOperatorEvaluator&) = delete;

const BinaryOperatorEvaluator& operator=(const BinaryOperatorEvaluator&) = delete;

private:
// ---------- member data --------------------------------
Op m_operator;
};
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaConstantEvaluator.h
Expand Up @@ -35,11 +35,11 @@ namespace reco {
double evaluate(double const* iVariables, double const* iParameters) const final;
std::vector<std::string> abstractSyntaxTree() const final;

private:
ConstantEvaluator(const ConstantEvaluator&) = delete;

const ConstantEvaluator& operator=(const ConstantEvaluator&) = delete;

private:
// ---------- member data --------------------------------
double m_value;
};
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaEvaluatorBase.h
Expand Up @@ -57,11 +57,11 @@ namespace reco {
unsigned int precedence() const { return m_precedence; }
void setPrecedenceToParenthesis() { m_precedence = static_cast<unsigned int>(Precedence::kParenthesis); }

private:
EvaluatorBase(const EvaluatorBase&) = delete;

const EvaluatorBase& operator=(const EvaluatorBase&) = delete;

private:
// ---------- member data --------------------------------
unsigned int m_precedence;
};
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaFunctionOneArgEvaluator.h
Expand Up @@ -45,11 +45,11 @@ namespace reco {
return ret;
}

private:
FunctionOneArgEvaluator(const FunctionOneArgEvaluator&) = delete;

const FunctionOneArgEvaluator& operator=(const FunctionOneArgEvaluator&) = delete;

private:
// ---------- member data --------------------------------
std::shared_ptr<EvaluatorBase> m_arg;
std::function<double(double)> m_function;
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaFunctionTwoArgsEvaluator.h
Expand Up @@ -48,11 +48,11 @@ namespace reco {
return ret;
}

private:
FunctionTwoArgsEvaluator(const FunctionTwoArgsEvaluator&) = delete;

const FunctionTwoArgsEvaluator& operator=(const FunctionTwoArgsEvaluator&) = delete;

private:
// ---------- member data --------------------------------
std::shared_ptr<EvaluatorBase> m_arg1;
std::shared_ptr<EvaluatorBase> m_arg2;
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaParameterEvaluator.h
Expand Up @@ -35,11 +35,11 @@ namespace reco {
double evaluate(double const* iVariables, double const* iParameters) const final;
std::vector<std::string> abstractSyntaxTree() const final;

private:
ParameterEvaluator(const ParameterEvaluator&) = delete;

const ParameterEvaluator& operator=(const ParameterEvaluator&) = delete;

private:
// ---------- member data --------------------------------
unsigned int m_index;
};
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaUnaryMinusEvaluator.h
Expand Up @@ -44,11 +44,11 @@ namespace reco {
return ret;
}

private:
UnaryMinusEvaluator(const UnaryMinusEvaluator&) = delete;

const UnaryMinusEvaluator& operator=(const UnaryMinusEvaluator&) = delete;

private:
// ---------- member data --------------------------------
std::shared_ptr<EvaluatorBase> m_arg;
};
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/Utils/src/formulaVariableEvaluator.h
Expand Up @@ -35,11 +35,11 @@ namespace reco {
double evaluate(double const* iVariables, double const* iParameters) const final;
std::vector<std::string> abstractSyntaxTree() const final;

private:
VariableEvaluator(const VariableEvaluator&) = delete;

const VariableEvaluator& operator=(const VariableEvaluator&) = delete;

private:
// ---------- member data --------------------------------
unsigned int m_index;
};
Expand Down