Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jet vertex for pfbreco #347

Merged
merged 3 commits into from Aug 25, 2013

Conversation

rappoccio
Copy link
Contributor

Adding new feature request to add jet vertex for PFBRECO.

@rappoccio
Copy link
Contributor Author

Hi, Folks,

Whoops... this is not supposed to be here, I thought there was an interface to my OWN github clone of 7_0_X and not the official one. Sorry about that, I screwed up. The testing is not done for this, please ignore it (or delete, or whatever).

Sorry about the newbie error!

Cheers,
Sal

@rappoccio
Copy link
Contributor Author

OK after the commit number 7b81f0, this is now ready for pull (simple feature, but had a type-o, now it is working).

Again, apologies for the error.

Cheers,
Sal

@slava77
Copy link
Contributor

slava77 commented Aug 15, 2013

That last commit was 7b812f0 ... just checking if you actually wanted this pull in the official repo (your previous message here is confusing)

@ghost ghost assigned rappoccio Aug 15, 2013
@rappoccio
Copy link
Contributor Author

Hi, Slava,

Yes, this should be included. Sorry for the confusion (still working out how the mechanics of the pull requests work).

@cmsbuild
Copy link
Contributor

The following categories have been rejected by speer (a.k.a. @thspeer on GitHub): Reconstruction

@cms-git-reconstruction

@ktf
Copy link
Contributor

ktf commented Aug 15, 2013

@nclopezo can you check this?

@ktf
Copy link
Contributor

ktf commented Aug 15, 2013

nevermind. I misread.

@ktf ktf closed this Aug 15, 2013
@ktf ktf reopened this Aug 15, 2013
@nclopezo
Copy link
Contributor

Hi,

I took these changes on top of CMSSW_7_0_X_2013-08-15-0200, I ran the unit tests and RelVals, all tests passed.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/120/consoleFull

@cmsbuild
Copy link
Contributor

The following categories have been signed by @vadler: Analysis

@cms-git-analysis

@slava77
Copy link
Contributor

slava77 commented Aug 23, 2013

working @slava77

@slava77
Copy link
Contributor

slava77 commented Aug 23, 2013

+1

Checked in CMSSW_7_0_X_2013-08-19-0200
sign246
No differences in RECO outputs (including EI)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes.

ktf added a commit that referenced this pull request Aug 25, 2013
@ktf ktf merged commit bcb45fb into cms-sw:CMSSW_7_0_X Aug 25, 2013
davidlt pushed a commit to davidlt/cmssw that referenced this pull request Feb 21, 2014
Added data externals for CalibCalorimetry/CaloMiscalibTools/data and Con...
makortel pushed a commit to makortel/cmssw that referenced this pull request Apr 22, 2015
added watchlist for apfeiffer1
arizzi added a commit to arizzi/cmssw that referenced this pull request Feb 5, 2016
Pileup weight update and new json
cmsbuild pushed a commit that referenced this pull request May 12, 2019
fwyzard pushed a commit to fwyzard/cmssw that referenced this pull request May 20, 2019
fwyzard pushed a commit to fwyzard/cmssw that referenced this pull request May 20, 2019
fwyzard pushed a commit to fwyzard/cmssw that referenced this pull request May 20, 2019
missirol pushed a commit to missirol/cmssw that referenced this pull request Oct 22, 2020
…devel

[HLTrigger] small tweaks to "L1EnergySumFilterT"
mandrenguyen pushed a commit to mandrenguyen/cmssw that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants