New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DQM: Add EMTF DQM plots on GEM information and their comparison to CSC inputs #34706
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34706/24340
|
A new Pull Request was created by @zuoxunwu (Xunwu Zuo) for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4601a/17375/summary.html Comparison SummarySummary:
|
@zuoxunwu all GEM plots seem empty in every workflow, while CSC ones have entries when created (as expected). |
Hi @jfernan2, thanks for the check! All plots in 14 TeV samples are empty (no CSC or GEM hits). I am not familiar with the workflow to understand if this is expected. Looks to me that there are no EMTFHits in these simulations. In any case, I do not think the issue (if it is an issue) is caused by this PR. FYI, in case it helps, I did run the DQM plots locally on a RelVal sample (/store/relval/CMSSW_12_0_0_pre4/RelValZMM_14/GEN-SIM-DIGI-RAW/120X_mcRun3_2021_realistic_v2-v1/00000/062257a2-badb-485f-bd55-810659b30d2d.root) Also adding some EMTF experts to the thread @eyigitba, @jiafulow. Thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is the first PR to include GEM information in the EMTF online DQM collection. Plots added cover GEM occupancy, timing, and comparison of GEM inputs to CSC inputs.
This PR also fixes a minor mistake in some CSC DQM plots where hits from neighboring chambers were filled in the wrong bins.
PR validation:
This development has been studied with RelVal ZMM samples and recent cosmic data. All DQM plots are generated and filled as expected. (As the GEM firmware is being tested and updated, EMTF does not receive meaningful inputs from GEM in cosmic runs for the moment. But the DQM part works fine.)
The PR passed local unit tests and matrix test.
Code format check was also run locally and code was updated accordingly.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport.
@eyigitba