Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DQM: Add EMTF DQM plots on GEM information and their comparison to CSC inputs #34706

Merged
merged 4 commits into from Aug 4, 2021

Conversation

zuoxunwu
Copy link
Contributor

PR description:

This PR is the first PR to include GEM information in the EMTF online DQM collection. Plots added cover GEM occupancy, timing, and comparison of GEM inputs to CSC inputs.
This PR also fixes a minor mistake in some CSC DQM plots where hits from neighboring chambers were filled in the wrong bins.

PR validation:

This development has been studied with RelVal ZMM samples and recent cosmic data. All DQM plots are generated and filled as expected. (As the GEM firmware is being tested and updated, EMTF does not receive meaningful inputs from GEM in cosmic runs for the moment. But the DQM part works fine.)
The PR passed local unit tests and matrix test.
Code format check was also run locally and code was updated accordingly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

@eyigitba

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34706/24340

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @zuoxunwu (Xunwu Zuo) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4601a/17375/summary.html
COMMIT: d97e223
CMSSW: CMSSW_12_1_X_2021-07-30-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34706/17375/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998531
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 13814.586 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 767.477 KiB L1T/L1TStage2EMTF
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

@zuoxunwu all GEM plots seem empty in every workflow, while CSC ones have entries when created (as expected).
Is this the right behaviour?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-07-30-0900+c4601a/44490/dqm-histo-comparison-summary.html
Thanks

@zuoxunwu
Copy link
Contributor Author

Hi @jfernan2, thanks for the check!
It looks the CSC hits are only filled in workflows 136.731, 136.793, 136.874, and 140.56, which are all Run 2 data samples. It is expected that there was no GEM signal in those runs.

All plots in 14 TeV samples are empty (no CSC or GEM hits). I am not familiar with the workflow to understand if this is expected. Looks to me that there are no EMTFHits in these simulations. In any case, I do not think the issue (if it is an issue) is caused by this PR.

FYI, in case it helps, I did run the DQM plots locally on a RelVal sample (/store/relval/CMSSW_12_0_0_pre4/RelValZMM_14/GEN-SIM-DIGI-RAW/120X_mcRun3_2021_realistic_v2-v1/00000/062257a2-badb-485f-bd55-810659b30d2d.root)
I have dumped the plots at https://xzuo.web.cern.ch/EMTF/pushtest_gem_relval_plots/. All plots look fine.

Also adding some EMTF experts to the thread @eyigitba, @jiafulow.

Thanks!

@jfernan2
Copy link
Contributor

jfernan2 commented Aug 4, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants