Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused header for Alignment/LaserAlignment and Alignment/MuonAlignmentAlgorithms #34715

Merged
merged 1 commit into from Aug 2, 2021

Conversation

yuanchao
Copy link
Contributor

@yuanchao yuanchao commented Aug 1, 2021

Remove unused header for ALCA packages #1

PR description:

Following the issue #31505, the following headers are unused in Alignment package:

  • Alignment/LaserAlignment/interface/OrderedLaserHitPair.h
  • Alignment/LaserAlignment/interface/OrderedLaserHitPairs.h
  • Alignment/LaserAlignment/interface/SeedLayerPairs.h
  • Alignment/MuonAlignmentAlgorithms/interface/MuonInfoTuple.h

This is the first batch of the removal.

PR validation:

Code compiles. Run local limited runTheMatrix.py tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport forseen

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2021

@yuanchao, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34715/24355

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2021

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

  • Alignment/LaserAlignment (alca)
  • Alignment/MuonAlignmentAlgorithms (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @abbiendi, @jhgoh, @tocheng, @mmusich, @trocino this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@yuanchao
Copy link
Contributor Author

yuanchao commented Aug 1, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4520/17401/summary.html
COMMIT: 662b06c
CMSSW: CMSSW_12_1_X_2021-08-01-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34715/17401/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4520/17401/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4520/17401/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998541
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 2, 2021

+alca

  • technical
  • tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2021

+1

@cmsbuild cmsbuild merged commit 3e98105 into cms-sw:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants