Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DQM onlinebeammonitor [11_3_X] #34721

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Aug 2, 2021

PR description:

Backport of #34719, fixes #34717
To be included in the next build for CRUZET 2021.

PR validation:

Compiles.
Also tested online and deployed the same configuration change in the HLT cosmics menu running in P5 (see http://cmsonline.cern.ch/cms-elog/1121707).

Backport:

Backport of #34719

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

A new Pull Request was created by @francescobrivio for CMSSW_11_3_X.

It involves the following packages:

  • DQM/Integration (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #34719

@francescobrivio
Copy link
Contributor Author

@jfernan2 @cms-sw/dqm-l2 could you please test this online at P5?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

Pull request #34721 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3adf5a/17427/summary.html
COMMIT: 4b9df2a
CMSSW: CMSSW_11_3_X_2021-08-01-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34721/17427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2878314
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2878291
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@rvenditti
Copy link
Contributor

This PR has been successfully tested in playback system in P5 online DQM with run 343082.

@rvenditti
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2021

@rvenditti could you please sign also the master version of this PR, which must be merged first?

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

+1
Now also successfully merged in master

@cmsbuild cmsbuild merged commit ec954c9 into cms-sw:CMSSW_11_3_X Aug 4, 2021
@francescobrivio francescobrivio deleted the alca-update_onlinebeammonitor_11_3_X branch August 9, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants