Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DQM onlinebeammonitor #34719

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Fixes #34717.
Added a VPSet to process.GlobalTag in onlinebeammonitor_dqm_sourceclient-live_cfg.py DQM client:

process.GlobalTag.toGet = cms.VPSet(
  cms.PSet(
    record = cms.string("BeamSpotOnlineLegacyObjectsRcd"),
    refreshTime = cms.uint64(1)
  ),
  cms.PSet(
    record = cms.string("BeamSpotOnlineHLTObjectsRcd"),
    refreshTime = cms.uint64(1)
  )
)

In this way the information about BeamSpotOnline is fetched every lumisection and the monitoring
actually reflects the behaviour of any other consumer of these tags (most notably the HLT).
Note that only the record name is needed in the toGet, this makes the client configuration resilient for
future changes of the tag names themselves.

PR validation:

Compiles.
Also tested online and deployed the same configuration change in the HLT cosmics menu running in P5 (see http://cmsonline.cern.ch/cms-elog/1121707).

Backport

Backports to 12_0_X (needed for CRAFT and BeamTest) and 11_3_X (for CRUZET) will be previded shortly.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34719/24358

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34719/24364

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

Pull request #34719 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2021

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4f9d2/17426/summary.html
COMMIT: b6aac13
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34719/17426/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
  • 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
  • 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

BTW this also failed in 12_0_X (#34726 (comment)) but not in 11_3_X (#34721 (comment)).

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2021

@qliphy @perrotta I guess this is a temporary glitch accessing the input files?
Should I re-trigger the tests right away?

Those RelVal Input tests are failing quite often, also in unrelated PR.
Thank you for having re-triggered the tests, would they fail again just ignore them.
(This is quite annoying: would a real error show up in those tests, I bet nobody will take care of...)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4f9d2/17451/summary.html
COMMIT: b6aac13
CMSSW: CMSSW_12_1_X_2021-08-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34719/17451/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1303 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 3678
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 2994845
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -45.703 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

Failures are:

  • wf 8.0 --> usual failure
  • wf 10224.0 --> only MessageLogger
  • wf 140.53 --> this is Run2011 HI, I have no idea why there are so many differences/failures here, should be completely unrelated to this PR

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2021

Failures are:

  • wf 8.0 --> usual failure
  • wf 10224.0 --> only MessageLogger
  • wf 140.53 --> this is Run2011 HI, I have no idea why there are so many differences/failures here, should be completely unrelated to this PR

@francescobrivio see #34719 (comment):
"The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons"

@mmusich
Copy link
Contributor

mmusich commented Aug 3, 2021

From #34719 (comment)

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@francescobrivio
Copy link
Contributor Author

thanks @perrotta and @mmusich I had missed that message!

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Aug 3, 2021

FYI the DQM team has also tested the 11_3_X backport live in their playback system in P5 and found no problems,
see #34721 (comment).

@jfernan2
Copy link
Contributor

jfernan2 commented Aug 3, 2021

+1
Backport #34721 tested in P5 DQM playback sucessfully

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to DQM onlinebeammonitor
5 participants