Remove unused headers of Calib- packages #34723

yuanchao · 2021-08-02T12:55:44Z

Remove unused headers for ALCA packages #2

PR description:

Following the issue #31505, the following headers are unused in Calib* package:

CalibCalorimetry/EcalLaserAnalyzer/interface/TMCORLin.h
CalibCalorimetry/EcalLaserAnalyzer/interface/TMCORSat.h
CalibCalorimetry/EcalLaserAnalyzer/interface/TMCReader.h
CalibCalorimetry/EcalLaserAnalyzer/interface/TMConfig.h
CalibCalorimetry/EcalLaserAnalyzer/interface/TMEGeom.h
CalibCalorimetry/EcalLaserAnalyzer/interface/TPEDestalAnalysis.h
CalibCalorimetry/HcalAlgos/interface/DoublePadeDelay.h
CalibCalorimetry/HcalAlgos/interface/equalADCSignalTime.h
CalibFormats/SiPixelObjects/interface/PixelAliasList.h
CalibFormats/SiPixelObjects/interface/PixelConfig.h
CalibFormats/SiPixelObjects/interface/PixelConfigAlias.h
CalibFormats/SiPixelObjects/interface/PixelConfigFile.h
CalibFormats/SiPixelObjects/interface/PixelConfigList.h
CalibFormats/SiPixelObjects/interface/PixelMaskOverride.h
CalibFormats/SiPixelObjects/interface/PixelTrimOverride.h
CalibFormats/SiPixelObjects/interface/PixelVersionAlias.h
CalibMuon/CSCCalibration/interface/CSCFakeCrosstalkMap.h
CalibMuon/CSCCalibration/interface/CSCFakeDBCrosstalkPopCon.h
CalibMuon/CSCCalibration/interface/CSCFakeDBGainsPopCon.h
CalibTracker/SiStripCommon/interface/SiStripBFieldFilter.h (does not exist in 12_1_x)
Calibration/IsolatedParticles/interface/CaloSimInfoExtra.h
Calibration/IsolatedParticles/interface/eECALMatrixExtra.h
Calibration/Tools/interface/TrackDetMatchInfoCollection.h
Calibration/Tools/interface/smartSelector.h

This is the second batch of the removal.

PR validation:

Code compiles. Run local limited runTheMatrix.py tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport forseen

cmsbuild · 2021-08-02T12:56:04Z

@yuanchao, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2021-08-02T13:03:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34723/24362

This PR adds an extra 16KB to repository

cmsbuild · 2021-08-02T13:04:18Z

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

CalibCalorimetry/EcalLaserAnalyzer (alca)
CalibCalorimetry/HcalAlgos (alca)
CalibFormats/SiPixelObjects (alca)
CalibMuon/CSCCalibration (alca)
Calibration/IsolatedParticles (alca)
Calibration/Tools (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @bsunanda, @thomreis, @simonepigazzini, @mmusich, @ptcox, @abdoulline, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

perrotta · 2021-08-02T13:07:32Z

please test

mmusich · 2021-08-02T13:36:58Z

@tvami @ferencek
are we positive these files

CalibFormats/SiPixelObjects/interface/PixelAliasList.h
CalibFormats/SiPixelObjects/interface/PixelConfig.h
CalibFormats/SiPixelObjects/interface/PixelConfigAlias.h
CalibFormats/SiPixelObjects/interface/PixelConfigFile.h
CalibFormats/SiPixelObjects/interface/PixelConfigList.h
CalibFormats/SiPixelObjects/interface/PixelMaskOverride.h
CalibFormats/SiPixelObjects/interface/PixelTrimOverride.h
CalibFormats/SiPixelObjects/interface/PixelVersionAlias.h

are not used by any of the commissioning activity s/w?

tvami · 2021-08-02T14:01:28Z

@tvami @ferencek
are we positive these files
are not used by any of the commissioning activity s/w?

Yes, I just followed up with this and learned that those files are kept in a a separate repository.

cmsbuild · 2021-08-02T17:40:59Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f88f0/17416/summary.html
COMMIT: 083fac5
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34723/17416/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11608.011608.0_SingleMuPt100+2021+SingleMuPt100_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleMuPt100+2021+SingleMuPt100_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998541
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-08-03T02:17:37Z

@cmsbuild , please test

hopefully the input errors are gone now

cmsbuild · 2021-08-03T10:04:53Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f88f0/17449/summary.html
COMMIT: 083fac5
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34723/17449/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11607.011607.0_SingleMuPt10+2021+SingleMuPt10_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleMuPt10+2021+SingleMuPt10_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11608.011608.0_SingleMuPt100+2021+SingleMuPt100_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleMuPt100+2021+SingleMuPt100_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998541
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-08-03T14:06:44Z

@cmsbuild , please test

cmsbuild · 2021-08-03T17:24:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f88f0/17469/summary.html
COMMIT: 083fac5
CMSSW: CMSSW_12_1_X_2021-08-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34723/17469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1303 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 3678
DQMHistoTests: Total nulls: 19
DQMHistoTests: Total successes: 2994845
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.703 KiB( 38 files compared)
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-08-03T17:29:40Z

+alca

technical PR

cmsbuild · 2021-08-03T17:30:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-08-03T17:41:23Z

+1

remove unused headers of Calib- packages

083fac5

cmsbuild changed the base branch from CMSSW_12_1_X to master August 2, 2021 12:56

cmsbuild added this to the CMSSW_12_1_X milestone Aug 2, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Aug 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 2, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 2, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 2, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 3, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 3, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 3, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 3, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Aug 3, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 3, 2021

cmsbuild merged commit ee17d60 into cms-sw:master Aug 3, 2021

tvami mentioned this pull request Aug 16, 2021

(A subset of) unused (header) files in cmssw #31505

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused headers of Calib- packages #34723

Remove unused headers of Calib- packages #34723

yuanchao commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

perrotta commented Aug 2, 2021

mmusich commented Aug 2, 2021

tvami commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

perrotta commented Aug 3, 2021

Remove unused headers of Calib- packages #34723

Remove unused headers of Calib- packages #34723

Conversation

yuanchao commented Aug 2, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

perrotta commented Aug 2, 2021

mmusich commented Aug 2, 2021

tvami commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

RelVals-INPUT

Comparison Summary

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

RelVals-INPUT

Comparison Summary

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

Comparison Summary

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

perrotta commented Aug 3, 2021