Fix params for Payload Inspector #34728

Dres90 · 2021-08-02T15:32:58Z

PR description:

When getting all data type for payload inspector, parameters were not being properly added to the returned dictionary. The lines adding these parameters was commented out. By uncommenting these lines the parameters are properly returned in the dictionary and displayed in the Browser.

francescobrivio · 2021-08-02T15:35:18Z

@Dres90 @tvami do we need a backport to 12_0_X ?

tvami · 2021-08-02T15:36:31Z

I don't think that's very important, the browser is already using 12_1_X

cmsbuild · 2021-08-02T15:39:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34728/24374

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/Utilities/scripts/getPayloadData.py modified in PR(s): Shift from Boost Python to Pybind11 #34692

cmsbuild · 2021-08-02T15:40:06Z

A new Pull Request was created by @Dres90 (Andrés Cárdenas) for master.

It involves the following packages:

CondCore/Utilities (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-08-02T15:40:49Z

@cmsbuild , please test

cmsbuild · 2021-08-02T21:14:52Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1d747/17433/summary.html
COMMIT: 4f0171d
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34728/17433/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1d747/17433/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1d747/17433/git-merge-result

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998535
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-08-03T01:31:35Z

@cmsbuild , please test

let's hope there are no input errors anymore

cmsbuild · 2021-08-03T09:50:20Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1d747/17448/summary.html
COMMIT: 4f0171d
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34728/17448/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1d747/17448/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1d747/17448/git-merge-result

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998535
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

mmusich · 2021-08-03T12:54:17Z

please test

cmsbuild · 2021-08-03T16:10:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1d747/17464/summary.html
COMMIT: 4f0171d
CMSSW: CMSSW_12_1_X_2021-08-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34728/17464/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1303 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 3677
DQMHistoTests: Total nulls: 20
DQMHistoTests: Total successes: 2994845
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.707 KiB( 38 files compared)
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

ggovi · 2021-08-10T14:36:50Z

+1

cmsbuild · 2021-08-11T06:51:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-08-11T08:52:29Z

+1

Dres90 added 2 commits August 2, 2021 17:29

Update getPayloadData.py

b07e094

Update getPayloadData.py

4f0171d

cmsbuild added this to the CMSSW_12_1_X milestone Aug 2, 2021

cmsbuild added code-checks-pending db-pending orp-pending pending-signatures tests-pending labels Aug 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 2, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 2, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 2, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 3, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 3, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 3, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 3, 2021

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Aug 11, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 11, 2021

cmsbuild merged commit 931b91d into cms-sw:master Aug 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix params for Payload Inspector #34728

Fix params for Payload Inspector #34728

Dres90 commented Aug 2, 2021

francescobrivio commented Aug 2, 2021

tvami commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

tvami commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

mmusich commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

ggovi commented Aug 10, 2021

cmsbuild commented Aug 11, 2021

qliphy commented Aug 11, 2021

Fix params for Payload Inspector #34728

Fix params for Payload Inspector #34728

Conversation

Dres90 commented Aug 2, 2021

PR description:

francescobrivio commented Aug 2, 2021

tvami commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

tvami commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

RelVals-INPUT

Comparison Summary

tvami commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

RelVals-INPUT

Comparison Summary

mmusich commented Aug 3, 2021

cmsbuild commented Aug 3, 2021

Comparison Summary

ggovi commented Aug 10, 2021

cmsbuild commented Aug 11, 2021

qliphy commented Aug 11, 2021