New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the interface to work with sherpa2. #3474
Conversation
…ous interface for sherpa2 is the change in the handling of the random nuber engine, here an unnamed namespace is used to store the first reference to the RNG to hand it over to the Sherpa external RNG class
This PR should test correctly after 240414-1400 IB. |
A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_7_1_X. Changed the interface to work with sherpa2. It involves the following packages: GeneratorInterface/SherpaInterface @vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks. |
+1 |
-1 >> Leaving Package FWCore/Version >> Package FWCore/Version built >> Subsystem FWCore built In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/sherpa/1.4.2-cms3/include/SHERPA-MC/ATOOLS/Math/Random.H:8:0, from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-24-0200/src/GeneratorInterface/SherpaInterface/src/SherpaHadronizer.cc:13: /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-24-0200/src/GeneratorInterface/SherpaInterface/src/SherpaHadronizer.cc:321:16: error: redefinition of 'class CMS_SHERPA_RNG' DECLARE_GETTER(CMS_SHERPA_RNG,"CMS_SHERPA_RNG",ATOOLS::External_RNG,ATOOLS::RNG_Key); ^ /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/sherpa/1.4.2-cms3/include/SHERPA-MC/ATOOLS/Org/Getter_Function.H:74:9: note: in definition of macro 'DECLARE_GETTER_BASE' class NAME: public ATOOLS::Getter_Function { \ ^ you can see the results of the tests here: |
Generators -- Changed the interface to work with sherpa2.
Apologies to @Degano for the cursing...;) |
The main changes to previous interface for sherpa2 is the change in the handling of the random nuber engine, here an unnamed namespace is used to store the first reference to the RNG to hand it over to the Sherpa external RNG class.