Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFormat] Cleanup unnecessary includes of DF private headers #34762

Merged
merged 1 commit into from Aug 5, 2021
Merged

[DataFormat] Cleanup unnecessary includes of DF private headers #34762

merged 1 commit into from Aug 5, 2021

Conversation

smuzaffar
Copy link
Contributor

As reported in #34718 , this PR removes the usage of DataFormats private header files

      2 src/DataFormats/FEDRawData/src/fed_header.h
      2 src/DataFormats/FEDRawData/src/fed_trailer.h
      1 src/DataFormats/MuonDetId/src/DTWireId.cc

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34762/24427

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CondFormats/DTObjects (db, alca)
  • EventFilter/Phase2TrackerRawToDigi (daq, reconstruction)
  • EventFilter/SiStripRawToDigi (reconstruction)

@perrotta, @malbouis, @yuanchao, @tlampen, @emeschi, @jpata, @slava77, @ggovi, @pohsun, @francescobrivio, @smorovic, @tvami can you please review it and eventually sign? Thanks.
@battibass, @pieterdavid, @robervalwalsh, @tocheng, @VinInn, @Martin-Grunewald, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4166a/17508/summary.html
COMMIT: d8b5e95
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34762/17508/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4166a/17508/llvm-analysis/esrget-sa.txt for details.
CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4166a/17508/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998541
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 4, 2021

+alca

@slava77
Copy link
Contributor

slava77 commented Aug 4, 2021

+reconstruction

for #34762 d8b5e95

  • code changes are technical, in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no differences

@smorovic
Copy link
Contributor

smorovic commented Aug 5, 2021

+daq

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

+1

  • @cms-sw/db-l2 this is pretty technical

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants