Phase2-TB63Z Rearrange the header file and make first example for dd4hep (replacing #34752)

[bsunanda]

PR description:

Rearrange the header file in SimG4CMS/HGCalTestBeam and make first example for dd4hep (replacing #34752)

PR validation:

Use the cfg's in SimG4CMS/HGCalTestBeam/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34791/24493

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimG4CMS/HGCalTestBeam (upgrade, simulation)

@civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d29449/17567/summary.html
COMMIT: 678f521
CMSSW: CMSSW_12_1_X_2021-08-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34791/17567/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , I am sorry, but recent requirement from @smuzaffar was to have include files for plugin inside plugin directory. This include files should not be used by any other class except producer itself HGCPassive.cc, normally these two files should be merged together into HGCPassive.cc, two separate files only if the producer is too big.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34791/24531

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #34791 was updated. @civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kpedro88 can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34791/24547

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • SimG4CMS/HGCalTestBeam/plugins/HGCPassive.cc:
    • Modified: 678f521, c75e71f, 1d34db3
    • Deleted: 6ed73a0
    • Added: fa6db2b
  • SimG4CMS/HGCalTestBeam/interface/HGCPassive.h:
    • Added: 678f521
    • Deleted: fa6db2b
  • SimG4CMS/HGCalTestBeam/plugins/module.cc:
    • Added: 8a26d82
    • Deleted: fa6db2b
  • SimG4CMS/HGCalTestBeam/src/HGCPassive.cc:
    • Added: 6ed73a0
    • Deleted: fa6db2b

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4CMS/HGCalTestBeam/plugins/BuildFile.xml modified in PR(s): Clean unused dependencies from BuildFiles #34809

[cmsbuild]

Pull request #34791 was updated. @civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kpedro88 can you please check and sign again.

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d29449/17616/summary.html
COMMIT: 1d34db3
CMSSW: CMSSW_12_1_X_2021-08-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34791/17616/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999381
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

Technical PR for the header file rearranging, and include new example for dd4hep. PR test runs fine without change as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1