[12_0_X] backport : HF SimHits timing fix

[abdoulline]

This PR is a backport

of 12_1_X PR #34786
contains HF SimHits timing fix to keep HF simulation in sync between 12_0 and 12_1

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for CMSSW_12_0_X.

It involves the following packages:

• Geometry/HcalSimData (geometry)
• SimCalorimetry/HcalSimProducers (simulation)
• SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @bsunanda, @thomreis, @cvuosalo, @simonepigazzini, @mariadalfonso, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e596e0/17591/summary.html
COMMIT: 20c7b7a
CMSSW: CMSSW_12_0_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34799/17591/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 11608.011608.0_SingleMuPt100+2021+SingleMuPt100_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleMuPt100+2021+SingleMuPt100_Eta2p85_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11634.111634.1_TTbar_14TeV+2021_trackingOnly+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST/step2_TTbar_14TeV+2021_trackingOnly+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST.log
• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11602.0
• 11603.0
• 11604.0
• 11605.0
• 11606.0
• 11607.0
• 11609.0
• 11630.0
• 11634.0
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.13
• 11834.24
• 11846.0
• 12634.0
• 11925.0
• 12034.0
• 12434.0
• 12834.0
• 13034.0
• 23434.21
• 23434.99
• 23434.9921
• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11132 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 61920
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 2936620
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 4 / 38 workflows

[abdoulline]

Run3/Phase2 HF SimHits timing changed as expected http://cern.ch/go/Wx8s

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

merge