Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] CocoaModel/src/Model.cc gcc11 compile error fix (issues #34756) #34808

Merged
merged 1 commit into from Aug 6, 2021

Conversation

hyunyong
Copy link
Contributor

@hyunyong hyunyong commented Aug 5, 2021

PR description:

fixes #34756

Remove two types: DIFFCENTRE and DIFFANGLE

These types are removed before but remained in the if statement.

@tvami

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34808/24533

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

  • Alignment/CocoaModel (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @adewit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

type bugfix

@francescobrivio
Copy link
Contributor

test parameters:

  • addpkg = Alignment/CocoaModel

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@tvami
Copy link
Contributor

tvami commented Aug 5, 2021

@cmsbuild , please abort

@tvami
Copy link
Contributor

tvami commented Aug 5, 2021

test parameters:

  • release = slc7_amd64_gcc11
  • addpkg = Alignment/CocoaModel

@tvami
Copy link
Contributor

tvami commented Aug 5, 2021

(the issue comes up with GCC 11)

@tvami
Copy link
Contributor

tvami commented Aug 5, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Aug 5, 2021

fixes #34756

@tvami
Copy link
Contributor

tvami commented Aug 5, 2021

@hyunyong I think it's prefered to have PR titles that explain the PR without the need to clicking to the issue, so would you please rename to something describing the problem? Thanks!

@hyunyong hyunyong changed the title [BUGFIX] issues #34756 [BUGFIX] CocoaModel/src/Model.cc gcc11 compile error fix (issues #34756) Aug 6, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3e4e/17597/summary.html
COMMIT: afd7335
CMSSW: CMSSW_12_1_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34808/17597/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999410
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999387
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 6, 2021

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 6, 2021

+1

@cmsbuild cmsbuild merged commit c172e64 into cms-sw:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCC 11] CocoaModel/src/Model.cc: error: 'this' pointer is null
5 participants