New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] CocoaModel/src/Model.cc gcc11 compile error fix (issues #34756) #34808
[BUGFIX] CocoaModel/src/Model.cc gcc11 compile error fix (issues #34756) #34808
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34808/24533
|
A new Pull Request was created by @hyunyong for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bugfix |
test parameters:
|
@cmsbuild please test |
@cmsbuild , please abort |
test parameters:
|
(the issue comes up with GCC 11) |
@cmsbuild , please test |
fixes #34756 |
@hyunyong I think it's prefered to have PR titles that explain the PR without the need to clicking to the issue, so would you please rename to something describing the problem? Thanks! |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3e4e/17597/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
fixes #34756
Remove two types: DIFFCENTRE and DIFFANGLE
These types are removed before but remained in the if statement.
@tvami