Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite an existing process.options in TimeMemorySummary customise #3485

Merged

Conversation

Dr15Jones
Copy link
Contributor

The customise function in TimeMemorySummary.py was overwriting a
process.options if one was already defined. When this customise was
used in conjunction with the customise which turned on threading,
this one turned off the threading.

…tomise

The customise function in TimeMemorySummary.py was overwriting a
process.options if one was already defined. When this customise was
used in conjunction with the customise which turned on threading,
this one turned off the threading.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Do not overwrite an existing process.options in TimeMemorySummary customise

It involves the following packages:

Validation/Performance

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

>> Building edm plugin tmp/slc6_amd64_gcc481/src/DQM/RCTMonitor/src/DQMRCTMonitor/libDQMRCTMonitor.so
Copying tmp/slc6_amd64_gcc481/src/SimCalorimetry/HcalSimProducers/src/SimCalorimetryHcalSimProducers/libSimCalorimetryHcalSimProducers.so to productstore area:
Leaving library rule at SimCalorimetry/HcalSimProducers
Leaving library rule at src/RecoLocalCalo/EcalRecProducers/test
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lCalibCalorimetryEcalTPGTools
collect2: error: ld returned 1 exit status
Leaving library rule at src/RecoLocalCalo/EcalRecProducers/test
>> Building shared library tmp/slc6_amd64_gcc481/src/DQMServices/Diagnostic/src/DQMServicesDiagnostic/libDQMServicesDiagnostic.so
gmake: **\* [tmp/slc6_amd64_gcc481/src/RecoLocalCalo/EcalRecProducers/plugins/RecoLocalCaloEcalRecProducersPlugins/libRecoLocalCaloEcalRecProducersPlugins.so] Error 1
gmake: **\* Waiting for unfinished jobs....
>> Building edm plugin tmp/slc6_amd64_gcc481/src/DQM/EcalPreshowerMonitorClient/src/DQMEcalPreshowerMonitorClient/libDQMEcalPreshowerMonitorClient.so


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3485/1016/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 24, 2014
…MemorySummary

Do not overwrite an existing process.options in TimeMemorySummary customise
@ktf ktf merged commit 01f2b82 into cms-sw:CMSSW_7_1_X Apr 24, 2014
@Dr15Jones Dr15Jones deleted the doNotClobberOptionsPSetInTimeMemorySummary branch May 6, 2014 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants