Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reco] Removed unnecessary include statements #34866

Merged
merged 2 commits into from Aug 17, 2021
Merged

[Reco] Removed unnecessary include statements #34866

merged 2 commits into from Aug 17, 2021

Conversation

smuzaffar
Copy link
Contributor

This should fix the following private header usage issue #34718 for

   1 src/RecoLocalCalo/HGCalRecProducers/plugins/KernelManagerHGCalCellPositions.h

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34866/24668

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CondFormats/HGCalObjects (upgrade, db, alca)
  • RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)

@perrotta, @malbouis, @yuanchao, @jpata, @tlampen, @kpedro88, @AdrianoDee, @srimanob, @slava77, @ggovi, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @apsallid, @clelange, @felicepantaleo, @rovere, @lgray, @cseez, @bsunanda, @pfs, @lecriste, @hatakeyamak, @tocheng, @mmusich, @ebrondol, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5eb0eb/17760/summary.html
COMMIT: 14d66e9
CMSSW: CMSSW_12_1_X_2021-08-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34866/17760/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999420
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2999391
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

…ellPositionsConditions.cc

Co-authored-by: Slava Krutelyov <slava77@gmail.com>
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34866/24689

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34866 was updated. @perrotta, @malbouis, @yuanchao, @jpata, @tlampen, @kpedro88, @AdrianoDee, @srimanob, @slava77, @ggovi, @pohsun, @francescobrivio, @tvami can you please check and sign again.

@ggovi
Copy link
Contributor

ggovi commented Aug 16, 2021

+1

@tvami
Copy link
Contributor

tvami commented Aug 16, 2021

+alca

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5eb0eb/17787/summary.html
COMMIT: f87a446
CMSSW: CMSSW_12_1_X_2021-08-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34866/17787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2021

+reconstruction

for #34866 f87a446

  • code changes are technical, in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show no relevant differences

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2021

+1

my previous was ignored

@perrotta
Copy link
Contributor

+1

  • @cms-sw/upgrade-l2 this is technical, and quite simple: let try to merge it

@perrotta
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants