Run3-gex88 Make P5 as the default for 2021 scenarios #34879
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34879/24680
|
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6be86/17784/summary.html Comparison SummarySummary:
|
| ("O5","T5","C1","M1","F1","P5") : "2021FlatMinus05Percent", | ||
| ("O5","T6","C1","M1","F1","P5") : "2021FlatMinus10Percent", | ||
| ("O5","T7","C1","M1","F1","P5") : "2021FlatPlus05Percent", | ||
| ("O5","T8","C1","M1","F1","P5") : "2021FlatPlus10Percent", | ||
| } | ||
|
|
||
| deprecatedSubdets = set([ "T1", "T2", "O1", "O2", "P1", "P2", "P3" ]) |
There was a problem hiding this comment.
Hi @bsunanda,
Don't you need to include P4 in deprecatedSubdets because it is not used elsewhere?
In addition, I still see ppsDict includes P1, P2, P3,
cmssw/Configuration/Geometry/python/dict2021Geometry.py
Lines 1951 to 2259 in 3e7e962
do we need to keep them? For 2026, I think we clean the deprecated ones.
Thanks.
There was a problem hiding this comment.
Let us keep them for a while till we finalize 2021 - once and for all
cmsbuild
added
code-checks-pending
tests-pending
and removed
tests-approved
code-checks-approved
labels
|
@cmsbuild Please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34879/24688
|
|
Pull request #34879 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @AdrianoDee, @srimanob, @mdhildreth can you please check and sign again. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6be86/17785/summary.html Comparison SummarySummary:
|
|
+Upgrade |
|
+1 @cvuosalo , this was agreed at Friday meeting |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Make P5 as the default for 2021 scenarios
PR validation:
Tested with standard workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special