Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DAQ) input source - minimum starting lumisection (113X - backport) #34925

Merged
merged 1 commit into from Aug 19, 2021

Conversation

smorovic
Copy link
Contributor

PR description:

Adds a minimum starting lumisection parameter as environment variable. Source will ignore data or EoL markers from earlier lumisections if provided from file broker.
This targets Hilton, so that skipping to LS with input data can be facilitated.

Another variable of similar name, which was unused, is removed.

PR validation:

Mechanism was tested in a live filter farm test system (BU-FU) and shown to work as intended.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #34912

specified lumisection. Replaces another unused environment variable
which was not used (new name used for backwards compatibility).
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_11_3_X.

It involves the following packages:

  • EventFilter/Utilities (daq, reconstruction)

@perrotta, @emeschi, @cmsbuild, @slava77, @jpata, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-818e15/17846/summary.html
COMMIT: 79ee3b2
CMSSW: CMSSW_11_3_X_2021-08-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34925/17846/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2878314
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2878291
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor Author

+1

@slava77
Copy link
Contributor

slava77 commented Aug 18, 2021

+reconstruction

for #34925 79ee3b2

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 19, 2021

+1

@cmsbuild cmsbuild merged commit b50cee6 into cms-sw:CMSSW_11_3_X Aug 19, 2021
@smorovic smorovic deleted the 113X-daq-start-from-ls branch August 24, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants