New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the TTTrack/TTTrack_TrackWord DataFormats #34988
Updates to the TTTrack/TTTrack_TrackWord DataFormats #34988
Conversation
…n to test the output of the digitize and undigitize functions. Convert from global to local phi during construction and setting of parameters and allow the TTTrack class to make use of this function from the base class. Finally, add some code to unit test the TTTrack_TrackWord; specifically the digitize and undigitize functions.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34988/24833
|
A new Pull Request was created by @aperloff (Alexx Perloff) for master. It involves the following packages:
@AdrianoDee, @kpedro88, @cmsbuild, @rekovic, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8689a8/17987/summary.html Comparison SummarySummary:
|
@AdrianoDee @srimanob @rekovic Is there something you would like to see done for this PR and #34970? If not, can you please review and possibly signoff on them? |
+1 |
+Upgrade The PR is in line with the PR description and the PR test runs fine. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a forward port of #34970. It has been rebased to work on the latest IB for the CMSSW_12_1_X series. This forward port was requested by @qliphy.
PR validation:
After rebasing I checked that the code compiled both without and with running
git-cms-checkdeps -a
. I also re-rancmsRun DataFormats/L1TrackTrigger/test/testDataFormatsTTTrackTrackWord_cfg.py
to make sure that the new code still returned the expected output.@tomalin