Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the TTTrack/TTTrack_TrackWord DataFormats #34988

Merged

Conversation

aperloff
Copy link
Contributor

PR description:

This PR is a forward port of #34970. It has been rebased to work on the latest IB for the CMSSW_12_1_X series. This forward port was requested by @qliphy.

PR validation:

After rebasing I checked that the code compiled both without and with running git-cms-checkdeps -a. I also re-ran cmsRun DataFormats/L1TrackTrigger/test/testDataFormatsTTTrackTrackWord_cfg.py to make sure that the new code still returned the expected output.

@tomalin

…n to test the output of the digitize and undigitize functions. Convert from global to local phi during construction and setting of parameters and allow the TTTrack class to make use of this function from the base class. Finally, add some code to unit test the TTTrack_TrackWord; specifically the digitize and undigitize functions.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34988/24833

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aperloff (Alexx Perloff) for master.

It involves the following packages:

  • DataFormats/L1TrackTrigger (upgrade, l1)
  • L1Trigger/L1TTrackMatch (upgrade, l1)

@AdrianoDee, @kpedro88, @cmsbuild, @rekovic, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @sviret this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8689a8/17987/summary.html
COMMIT: f5a1bc5
CMSSW: CMSSW_12_1_X_2021-08-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34988/17987/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000330
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@aperloff
Copy link
Contributor Author

@AdrianoDee @srimanob @rekovic Is there something you would like to see done for this PR and #34970? If not, can you please review and possibly signoff on them?

@rekovic
Copy link
Contributor

rekovic commented Aug 31, 2021

+1

@srimanob
Copy link
Contributor

+Upgrade

The PR is in line with the PR description and the PR test runs fine.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 1, 2021

+1

@cmsbuild cmsbuild merged commit c7d4a31 into cms-sw:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants