Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities/StaticAnalyzers: Update function dumper to not add virtual at the end of function calls #35001

Merged
merged 2 commits into from Aug 25, 2021
Merged

Utilities/StaticAnalyzers: Update function dumper to not add virtual at the end of function calls #35001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eae84f
Utilities/StaticAnalyzers: Update function dumper to not add virtual …
gartung Aug 24, 2021
04d9e3e
Add -enable-checker deprecated
gartung Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Utilities/StaticAnalyzers/scripts/run_class_checker.sh
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ cd ${LOCALRT}/src/Utilities/StaticAnalyzers
scram b -j $J
cd ${LOCALRT}/
export USER_CXXFLAGS="-DEDM_ML_DEBUG -w"
export USER_LLVM_CHECKERS="-enable-checker threadsafety -enable-checker optional.ClassChecker -enable-checker cms -disable-checker cms.FunctionDumper"
export USER_LLVM_CHECKERS="-enable-checker threadsafety -enable-checker optional.ClassChecker -enable-checker cms -enable-checker deprecated -disable-checker cms.FunctionDumper"
scram b -k -j $J checker SCRAM_IGNORE_PACKAGES=Fireworks/% SCRAM_IGNORE_SUBDIRS=test > ${LOCALRT}/tmp/class+function-checker.log 2>&1
cd ${LOCALRT}/tmp/
touch check-end
Expand Down
6 changes: 3 additions & 3 deletions Utilities/StaticAnalyzers/src/ClangCmsCheckerPluginRegister.cpp
View file
Open in desktop
Expand Up @@ -69,7 +69,7 @@ extern "C" void clang_registerCheckers(clang::ento::CheckerRegistry &registry) {
registry.addChecker<clangcms::CatchAll>(
"cms.CodeRules.CatchAll", "Checks for 'catch(...)' in source files", "no docs");
registry.addChecker<clangcms::edmChecker>(
"cms.edmChecker",
"deprecated.edmChecker",
"Flags classes inheriting from edm::EDProducer,edm::EDFilter,edm::Analyzer or edm::OutputModule",
"no docs");
registry.addChecker<clangcms::getByChecker>(
Expand All @@ -85,9 +85,9 @@ extern "C" void clang_registerCheckers(clang::ento::CheckerRegistry &registry) {
registry.addChecker<clangcms::EDMPluginDumper>(
"optional.EDMPluginDumper", "Dumps macro DEFINE_EDM_PLUGIN types", "no docs");
registry.addChecker<clangcms::ThrUnsafeFCallChecker>(
"cms.ThrUnsafeFCallChecker", "Reports calls of known thread unsafe functions", "no docs");
"threadsafety.ThrUnsafeFCallChecker", "Reports calls of known thread unsafe functions", "no docs");
registry.addChecker<clangcms::ESRGetChecker>(
"threadsafety.ESRecordGetChecker", "Checks for calls to EventSetupRecord::get", "no docs");
"deprecated.ESRecordGetChecker", "Checks for calls to EventSetupRecord::get", "no docs");
}

extern "C" const char clang_analyzerAPIVersionString[] = CLANG_ANALYZER_API_VERSION_STRING;
2 changes: 1 addition & 1 deletion Utilities/StaticAnalyzers/src/ESRecordGetChecker.cpp
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@ namespace clangcms {
"the token see "
"https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit";
PathDiagnosticLocation CELoc = PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), AC);
BugType *BT = new BugType(Checker, "EventSetupRecord::get function called", "ThreadSafety");
BugType *BT = new BugType(Checker, "EventSetupRecord::get function called", "Deprecated API");
std::unique_ptr<BasicBugReport> R = std::make_unique<BasicBugReport>(*BT, llvm::StringRef(os.str()), CELoc);
R->addRange(CE->getSourceRange());
BR.emitReport(std::move(R));
Expand Down
12 changes: 3 additions & 9 deletions Utilities/StaticAnalyzers/src/FunctionDumper.cpp
View file
Open in desktop
Expand Up @@ -137,10 +137,7 @@ namespace clangcms {
fixAnonNS(mname);
std::string tname = "function-dumper.txt.unsorted";
std::string ostring;
if (MD->isVirtual())
ostring = "function '" + mdname + "' " + "calls function '" + mname + " virtual'\n";
else
ostring = "function '" + mdname + "' " + "calls function '" + mname + "'\n";
ostring = "function '" + mdname + "' " + "calls function '" + mname + "'\n";
support::writeLog(ostring, tname);

VisitChildren(CXE);
Expand All @@ -166,10 +163,7 @@ namespace clangcms {
mname = support::getQualifiedName(*FD);
std::string tname = "function-dumper.txt.unsorted";
std::string ostring;
if (FD->isVirtualAsWritten() || FD->isPure())
ostring = "function '" + mdname + "' " + "calls function '" + mname + " virtual'\n";
else
ostring = "function '" + mdname + "' " + "calls function '" + mname + "'\n";
ostring = "function '" + mdname + "' " + "calls function '" + mname + "'\n";
support::writeLog(ostring, tname);

VisitChildren(CE);
Expand All @@ -194,7 +188,7 @@ namespace clangcms {
for (auto I = MD->begin_overridden_methods(), E = MD->end_overridden_methods(); I != E; ++I) {
std::string oname = support::getQualifiedName(*(*I));
walker.fixAnonNS(oname);
std::string ostring = "function '" + mname + "' " + "overrides function '" + oname + " virtual'\n";
std::string ostring = "function '" + mname + "' " + "overrides function '" + oname + "'\n";
support::writeLog(ostring, tname);
}
return;
Expand Down
2 changes: 1 addition & 1 deletion Utilities/StaticAnalyzers/src/edmChecker.cpp
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ namespace clangcms {
BR.EmitBasicReport(RD,
this,
"inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule",
"ThreadSafety",
"Deprecated API",
os.str(),
ELoc);
}
Expand Down
4 changes: 2 additions & 2 deletions Utilities/StaticAnalyzers/src/getByChecker.cpp
View file
Open in desktop
Expand Up @@ -101,7 +101,7 @@ namespace clangcms {

// llvm::errs()<<os.str()<<"\n";
PathDiagnosticLocation CELoc = PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), AC);
BugType *BT = new BugType(Checker, "edm::getByLabel or edm::getManyByType called", "optional");
BugType *BT = new BugType(Checker, "edm::getByLabel or edm::getManyByType called", "Deprecated API");
std::unique_ptr<BasicBugReport> R = std::make_unique<BasicBugReport>(*BT, llvm::StringRef(os.str()), CELoc);
R->addRange(CE->getSourceRange());
BR.emitReport(std::move(R));
Expand All @@ -124,7 +124,7 @@ namespace clangcms {
// (*I)->printPretty(llvm::errs(),0,Policy);
// llvm::errs()<<" "<<qtname<<"\n";
PathDiagnosticLocation CELoc = PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), AC);
BugType *BT = new BugType(Checker, "function call with argument of type edm::Event", "optional");
BugType *BT = new BugType(Checker, "function call with argument of type edm::Event", "Deprecated API");
std::unique_ptr<BasicBugReport> R = std::make_unique<BasicBugReport>(*BT, llvm::StringRef(os.str()), CELoc);
R->addRange(CE->getSourceRange());
BR.emitReport(std::move(R));
Expand Down