PCL of diamond sampic offset calibration #35029
Conversation
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35029/24887
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35029/24888
|
|
A new Pull Request was created by @ChrisMisan (Christopher) for master. It involves the following packages:
@perrotta, @malbouis, @andrius-k, @yuanchao, @kmaeshima, @davidlange6, @ErnestaP, @ahmad3213, @rvenditti, @cmsbuild, @jfernan2, @tlampen, @qliphy, @pohsun, @francescobrivio, @fabiocos, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild , please test |
|
Hi @ChrisMisan can you please include a link to your presentation on Monday in the description of the PR (for future references), https://indico.cern.ch/event/1069114/#15-pps-time-alignment-of-diamo ? |
|
-1 Failed Tests: Build BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02695/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PPSDiamondSampicTimingCalibrationPCLHarvester.cc:(.text._ZNK3edm10eventsetup30EventSetupRecordImplementationI23PPSTimingCalibrationRcdE3keyEv[_ZNK3edm10eventsetup30EventSetupRecordImplementationI23PPSTimingCalibrationRcdE3keyEv]+0xb): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()' /cvmfs/cms-ib.cern.ch/nweek-02695/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CalibPPS/TimingCalibration/plugins/CalibPPSTimingCalibrationPlugins/PPSDiamondSampicTimingCalibrationPCLHarvester.cc.o: in function `PPSDiamondSampicTimingCalibrationPCLHarvester::beginRun(edm::Run const&, edm::EventSetup const&) [clone .cold]': PPSDiamondSampicTimingCalibrationPCLHarvester.cc:(.text.unlikely+0x133): undefined reference to `char const* edm::typelookup::className()' /cvmfs/cms-ib.cern.ch/nweek-02695/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PPSDiamondSampicTimingCalibrationPCLHarvester.cc:(.text.unlikely+0x13c): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()' /cvmfs/cms-ib.cern.ch/nweek-02695/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PPSDiamondSampicTimingCalibrationPCLHarvester.cc:(.text.unlikely+0x17c): undefined reference to `char const* edm::typelookup::className()' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc900/src/CalibPPS/TimingCalibration/plugins/CalibPPSTimingCalibrationPlugins/libCalibPPSTimingCalibrationPlugins.so] Error 1 Leaving library rule at src/CalibPPS/TimingCalibration/plugins >> Leaving Package CalibPPS/TimingCalibration >> Package CalibPPS/TimingCalibration built >> Entering Package Utilities/StaticAnalyzers |
cmsbuild
added
code-checks-approved
tests-started
and removed
code-checks-pending
labels
|
Pull request #35029 was updated. @perrotta, @malbouis, @andrius-k, @yuanchao, @kmaeshima, @davidlange6, @ErnestaP, @ahmad3213, @rvenditti, @jfernan2, @qliphy, @francescobrivio, @fabiocos, @tvami can you please check and sign again. |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
|
The error is not related to this PR, we will re-trigger tests later |
|
@cmsbuild , please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2703cb/18270/summary.html Comparison SummarySummary:
|
|
+1 |
|
+alca |
|
+1 |
cmsbuild
added
fully-signed
operations-approved
orp-approved
and removed
operations-pending
pending-signatures
orp-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR introduces PCL module for Diamond Sampic offset calibration, main components are:
worker - which can work in parallel and is gathering statistics from recHits and Digi
harvester - which is calculating an offset by acquiring the channel mean and subtracting it from the previous offset. In order to do so harvester is using aggregated histograms provided by workers. Results are then saved in corresponding db object.
Additionally, PR contains DQM module which is suppose to run after the diamond sampic reconstruction and produce plots relevant for the validation of current offset.
PR validation:
PR was successfully tested locally(run file&configuration included in /CalibPPS/TimingCalibration/test). In addition, the matrix test was conducted, yielding expected null structure.
PR presentation: https://indico.cern.ch/event/1069114/#15-pps-time-alignment-of-diamo
for the reference-memory consumption results presented during alcaDb meeting:
