address UB in EnergyUncertaintyPhotonSpecific.cc

[afiqaize]

PR description:

Code changes address #35036

Problem is caused by function being called with brem = nan. Did not investigate why this is happening.

Also took the chance to improve the readability of the parameter arrays, and removed a redundant logic.

PR validation:

Code compiles, and checked that the block that triggered UB is no longer reached with nan calls.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35045/24915

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @afiqaize (Afiq Anuar) for master.

It involves the following packages:

• RecoEgamma/EgammaPhotonAlgos (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[slava77]

@afiqaize
thank you for the prompt submission of the PR.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cf577/18091/summary.html
COMMIT: f7faeb4
CMSSW: CMSSW_12_1_X_2021-08-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35045/18091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35045 f7faeb4

• code changes are in line with the PR description, including a technical update in the array filling/formatting
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1