Initialize fields in ProcessCallGraph and HLTRegionalEcalResonanceFilter

[mrodozov]

PR description:

Fixes 2 of 3 issues on #35008

This is initializing two boolean fields - one is the nested NodeType struct scheduled_ field,
for which the default constructor is used to keep the fields untouched (instead of setting scheduled_=false )
The other is store5x5RecHitEB_ which follows in a state where if if (doSelBarrel_) is false, store5x5RecHitEB_ remains uninitialized and is later used here:
https://github.com/cms-sw/cmssw/blob/master/HLTrigger/special/plugins/HLTRegionalEcalResonanceFilter.cc#L613
which is causing the error.

PR validation:

After the change the sanitizer doesn't complain (the logs aren't showing the errors)

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35066/24947

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

• HLTrigger/Timer (hlt)
• HLTrigger/special (hlt)

@Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cb579/18124/summary.html
COMMIT: 436d6be
CMSSW: CMSSW_12_1_X_2021-08-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35066/18124/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:14:
/cvmfs/cms-ib.cern.ch/nweek-02695/slc7_amd64_gcc900/external/boost/1.75.0-dhcijl/include/boost/detail/iterator.hpp:13:1: note: #pragma message: This header is deprecated. Use  instead.
   13 | BOOST_HEADER_DEPRECATED("")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc: In member function 'void ProcessCallGraph::preSourceConstruction(const edm::ModuleDescription&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:57:75: error: no match for 'operator=' (operand types are 'boost::adjacency_list, boost::property > >::vertex_bundled' {aka 'ProcessCallGraph::NodeType'} and '')
   57 |   graph_.m_graph[module.id()] = {module, edm::EDMModuleType::kSource, true};
      |                                                                           ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:30:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/interface/ProcessCallGraph.h:29:10: note: candidate: 'ProcessCallGraph::NodeType& ProcessCallGraph::NodeType::operator=(const ProcessCallGraph::NodeType&)'
   29 |   struct NodeType {


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

Entering library rule at HLTrigger/Timer
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/EDMModuleType.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/memory_usage.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/processor_model.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:57:31: error: no viable overloaded '='
  graph_.m_graph[module.id()] = {module, edm::EDMModuleType::kSource, true};
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/interface/ProcessCallGraph.h:29:10: note: candidate function (the implicit move assignment operator) not viable: cannot convert initializer list argument to 'ProcessCallGraph::NodeType'
  struct NodeType {
         ^


[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35066/24948

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #35066 was updated. @Martin-Grunewald can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cb579/18125/summary.html
COMMIT: 773673c
CMSSW: CMSSW_12_1_X_2021-08-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35066/18125/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000318
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1