Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_0_X] Better handling of timeout in FWCore/SharedMemory #35076

Merged
merged 3 commits into from Aug 31, 2021
Merged

[12_0_X] Better handling of timeout in FWCore/SharedMemory #35076

merged 3 commits into from Aug 31, 2021

Conversation

colizz
Copy link
Contributor

@colizz colizz commented Aug 30, 2021

PR description:

Backport of #34815. (commits are cherry-picked)

The backport is needed in 12_0_X because some POG samples will use concurrent GEN utilities, with Run 3 condition under this environment.

PR validation:

Unit tests work.

@Dr15Jones @colizz
Better handling of timeout in FWCore/SharedMemory
898b013 
The call to timed_wait will still take just as long as it takes the Worker to complete but will then return false if that time was longer than the set wait time.
Now we use transitionID_ to signify if the worker did the work and if it did, we ignore the timeout.
Added new `retry` methods which allow user control of what to do if a timeout does happen.
@Dr15Jones @colizz
Make algorithm logic clearer
5e4077c
@Dr15Jones @colizz
Share code across tests
472ca8a
@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Aug 30, 2021
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @colizz (Congqiao Li) for CMSSW_12_0_X.

It involves the following packages:

  • FWCore/SharedMemory (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99b21d/18143/summary.html
COMMIT: 472ca8a
CMSSW: CMSSW_12_0_X_2021-08-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35076/18143/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 31, 2021

+1

@cmsbuild cmsbuild merged commit c8dbfef into cms-sw:CMSSW_12_0_X Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colizz @cmsbuild @makortel @qliphy @Dr15Jones