Run endStream concurrently as part of endJob

[Dr15Jones]

PR description:

• Run the different streams and SubProcesses concurrently at the EndStream transition.

PR validation:

Code compiles and framework unit tests pass.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35097/24983

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa9b/18181/summary.html
COMMIT: ac77993
CMSSW: CMSSW_12_1_X_2021-08-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35097/18181/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @colizz Fix the random segfault of RelVal workflow 573 #35072

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa9b/18181/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa9b/18181/git-merge-result

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[makortel]

From visual inspection the only question I have is if we should eventually do the same for beginStream?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35097/24984

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #35097 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa9b/18182/summary.html
COMMIT: 2601610
CMSSW: CMSSW_12_1_X_2021-08-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35097/18182/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @colizz Fix the random segfault of RelVal workflow 573 #35072

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa9b/18182/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa9b/18182/git-merge-result

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1303 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 3676
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2996686
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.699 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[makortel]

Could this PR be causing many failures at the end of the jobs in IBs along

dropped waiting message count 0
----- Begin Fatal Exception 01-Sep-2021 19:40:33 CEST-----------------------
An exception of category 'MultipleExceptions' occurred while
   [0] Calling endJob
Exception Message:
Multiple exceptions were thrown while executing endJob. An exception message follows for each.
1
An exception of category 'NotFound' occurred while
   [0] Calling endStream for module MixingModule/'mix'
Exception Message:
Service no ServiceRegistry has been set for this thread 
2
An exception of category 'NotFound' occurred while
   [0] Calling endStream for module MixingModule/'mix'
Exception Message:
Service no ServiceRegistry has been set for this thread 
3
An exception of category 'NotFound' occurred while
   [0] Calling endStream for module MixingModule/'mix'
Exception Message:
Service no ServiceRegistry has been set for this thread 
----- End Fatal Exception -------------------------------------------------

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_1_X_2021-09-01-1100/pyRelValMatrixLogs/run/300.0_Pyquen_GammaJet_pt20_2760GeV+Pyquen_GammaJet_pt20_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO/step1_Pyquen_GammaJet_pt20_2760GeV+Pyquen_GammaJet_pt20_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO.log#/

[qliphy]

@Dr15Jones
I could reproduce the IB issue using "runTheMatrix.py -l 200 --job-reports -t 4 --ibeos"

CMSSW_12_1_X_2021-08-31-2300: works well
CMSSW_12_1_X_2021-08-31-2300 + this PR: give the issue

while "runTheMatrix.py -l 200" with this PR also runs well, that is why the PR test doesn't catch this error.

Do you have a workaround quickly? Or otherwise we revert this PR as quite many workflows in IB are failing?

[Dr15Jones]

@qliphy I'll have a fix in a few minutes.

[Dr15Jones]

@qliphy fixed in #35120