Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert NavigationSchool using modules back to legacy #3515

Conversation

Dr15Jones
Copy link
Contributor

Valgrind found that NavigationSchool obtained from the EventSetup
is not thread safe. Therefore we reverted all modules using that
instance back to legacy types until the issue can be solved.

Valgrind found that NavigationSchool obtained from the EventSetup
is not thread safe. Therefore we reverted all modules using that
instance back to legacy types until the issue can be solved.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Revert NavigationSchool using modules back to legacy

It involves the following packages:

RecoEgamma/EgammaPhotonProducers
RecoTracker/TrackProducer

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @lgray, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Apr 26, 2014

+1

for #3515 b3fda7c

tested in CMSSW_7_1_X_2014-04-26-1000
(test area sign359 in a combination of pulls 3503 3512 3513 3514 3515 3517)
no differences in reco outputs based on the short matrix test (15 workflows)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 27, 2014
…dulesBackToLegacy

Multithreading -- Revert NavigationSchool using modules back to legacy
@ktf ktf merged commit 8141151 into cms-sw:CMSSW_7_1_X Apr 27, 2014
@Dr15Jones Dr15Jones deleted the revertNavigationSchoolUsingModulesBackToLegacy branch May 6, 2014 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants