[HGCAL] Introduce SimTracksters linking

[lecriste]

PR description:

This PR:

• introduces a vector of indexes between the two SimTracksters collections, and store it into the event;
• improve the assignment of the regressed energy to the SimTracksters;
• replaces the SimTracksters collection to be used in the corresponding Validation section.

No changes are expected in the output except for the "TSToCP_linking" DQM Validation section.

PR validation:

runTheMatrix -l limited

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35158/25087

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

• RecoHGCal/TICL (upgrade, reconstruction)
• Validation/HGCalValidation (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @sobhatta, @pfs, @hatakeyamak, @ebrondol, @clelange this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff9c09/18328/summary.html
COMMIT: 15c89d4
CMSSW: CMSSW_12_1_X_2021-09-05-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35158/18328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000491
• DQMHistoTests: Total failures: 684
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999785
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

@lecriste are differences like
https://tinyurl.com/yjjearyo
https://tinyurl.com/ygvywqau
expected/understood?

I am confused from your PR description:
"No changes are expected in the output since the Validation section concerned contained already a filter on the input collection objects which screens the replacement in the third bullet above."

[lecriste]

@lecriste are differences like
https://tinyurl.com/yjjearyo
https://tinyurl.com/ygvywqau
expected/understood?

@jfernan2 yes, those differences are expected:

• lower number of reference truth objects,
• worse overall metrics.

In a following PR, we will fill the same Validation plots with the sibling SimTracksters collection and the metrics will improve again.

I am confused from your PR description:
"No changes are expected in the output since the Validation section concerned contained already a filter on the input collection objects which screens the replacement in the third bullet above."

I meant that "No changes are expected in the output except for the Validation section concerned", sorry for not being clear. Shall I clarify the PR description?

[jpata]

No reco differences observed, good. I agree that the description might be clarified to mention that the Validation particles in DQM are expected to change.
Minor code comments inline.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35158/25107

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35158 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @slava77, @jpata, @rvenditti can you please check and sign again.

[AdrianoDee]

please test

[lecriste]

• https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35158/25106/code-checks.patch

@smuzaffar FYI this patch is incorrect.

[smuzaffar]

@lecriste I am lookin in to it.

[smuzaffar]

looks like a bug in clang-tidy

clang-tidy -export-fixes foo.yaml -header-filter '/build/muz/tidy/CMSSW_12_1_X_2021-09-06-2300/src/.*'  src/RecoHGCal/TICL/plugins/SimTrackstersProducer.cc                                    1337 warnings generated.
RecoHGCal/TICL/plugins/SimTrackstersProducer.cc:169:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
        if (result->size() < 1)
            ^~~~~~~~~~~~~~~~~~
            result->->empty()
/cvmfs/cms-ib.cern.ch/nweek-02697/slc7_amd64_gcc900/external/gcc/9.3.0/lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../include/c++/9.3.0/bits/stl_vector.h:1004:7: note: method 'vector'::empty() defined here
      empty() const _GLIBCXX_NOEXCEPT

I will open a bug report with llvm if it not already there

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff9c09/18357/summary.html
COMMIT: 5979802
CMSSW: CMSSW_12_1_X_2021-09-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35158/18357/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 684
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000295
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[AdrianoDee]

+upgrade

• code changes consistent with the PR description
• following PR will address the needed changes to restore the metrics in the validation plots (e.g. here)

[jpata]

+reconstruction

• for 5979802
• technical, no relevant reco changes
• 1325.81 differences look like from Non-reproducibility in DeepTau in 1325.81 #32628, 11634.911 differences look like from Instabilities in 11634.911 (DD4Hep) workflow comparisons #35109

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1