Fix laser correction timing error in Ecal DQM [CMSSW_12_0_X]

[abhih1]

PR description:

This PR addresses the issue #35014. The time stamp of the event was not set correctly which when sent as an argument to the laser correction function gave false values. This is now rectified.

PR validation:

The warning message was reproduced by running:
For 2020 MWGR

cmsDriver.py step2 --conditions auto:run3_data_prompt --customise Configuration/DataProcessing/RecoTLR.customisePrompt,Configuration/DataProcessing/RecoTLR.customiseCosmicData --data --datatier RECO,DQMIO --era Run3 --eventcontent RECO,DQM --filein /store/express/Commissioning2020/ExpressCosmics/FEVT/Express-v1/000/338/714/00000/000D25B4-AE2B-ED4D-A539-F6EF7CDD527E.root --fileout "file:step2.root" --nThreads 8 --no_exec --number 1 --process reRECO --python_filename step_2_cfg.py --scenario cosmics --step RAW2DIGI,L1Reco,RECO,DQM

cmsRun  step_2_cfg.py

For 2021 CRUZET

cmsDriver.py step2 --conditions auto:run3_data_prompt --customise Configuration/DataProcessing/RecoTLR.customisePrompt,Configuration/DataProcessing/RecoTLR.customiseCosmicData --data --datatier RECO,DQMIO --era Run3 --eventcontent RECO,DQM --filein /store/express/Commissioning2021/ExpressCosmics/FEVT/Express-v1/000/344/518/00000/0147726b-df3d-467c-b802-17f26ff1ae92.root --fileout "file:step2.root" --nThreads 8 --no_exec --number 1 --process reRECO --python_filename step_2_cfg.py --scenario cosmics --step RAW2DIGI,L1Reco,RECO,DQM

cmsRun  step_2_cfg.py

After the changes were implemented the message no longer appears on running the same.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport to the PR in master: #35163
This is done to have the changes available in CMSSW_12_0_X which will be used for CRAFT and test beams.

[cmsbuild]

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_0_X.

It involves the following packages:

• DQM/EcalMonitorTasks (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix laser correction timing error in Ecal DQM #35163

[francescobrivio]

type bug-fix

[francescobrivio]

backport of #35163

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e94667/18341/summary.html
COMMIT: 58e50ae
CMSSW: CMSSW_12_0_X_2021-09-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35171/18341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

Differences in the Jenkins are expected and discussed in the master PR

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1