Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LowPtElectrons: fix for UL FastSim mini v2 and nano v9 workflows #35181

Merged
merged 4 commits into from Sep 17, 2021
Merged

LowPtElectrons: fix for UL FastSim mini v2 and nano v9 workflows #35181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f661be2
do NOT take 'closest' track from generalTracksBeforeMixing for FastSim
bainbrid Sep 7, 2021
11131ac
ID producer uses seed track instead of closest, for UL FastSim mini v…
bainbrid Sep 7, 2021
dd17b74
slava review
bainbrid Sep 10, 2021
0212d1d
Slava review
bainbrid Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion RecoEgamma/EgammaElectronProducers/interface/LowPtGsfElectronFeatures.h
View file
Open in desktop
Expand Up @@ -11,6 +11,10 @@
#include "RecoEcal/EgammaCoreTools/interface/EcalClusterLazyTools.h"
#include <vector>

namespace reco {
class Track;
}

namespace lowptgsfeleseed {

std::vector<float> features(const reco::PreId& ecal,
Expand All @@ -24,7 +28,8 @@ namespace lowptgsfeleseed {
namespace lowptgsfeleid {

// feature list for new model (2019Sept15)
std::vector<float> features_V1(reco::GsfElectron const& ele, float rho, float unbiased, float field_z);
std::vector<float> features_V1(
reco::GsfElectron const& ele, float rho, float unbiased, float field_z, const reco::Track* trk = nullptr);

// feature list for original models (2019Aug07 and earlier)
std::vector<float> features_V0(reco::GsfElectron const& ele, float rho, float unbiased);
Expand Down
87 changes: 77 additions & 10 deletions RecoEgamma/EgammaElectronProducers/plugins/LowPtGsfElectronIDProducer.cc
View file
Open in desktop
Expand Up @@ -12,6 +12,7 @@
#include "CommonTools/MVAUtils/interface/GBRForestTools.h"
#include "DataFormats/EgammaCandidates/interface/GsfElectron.h"
#include "DataFormats/PatCandidates/interface/Electron.h"
#include "DataFormats/PatCandidates/interface/PackedCandidate.h"
#include "DataFormats/EgammaReco/interface/SuperCluster.h"
#include "DataFormats/GsfTrackReco/interface/GsfTrack.h"
#include "DataFormats/TrackReco/interface/Track.h"
Expand All @@ -34,14 +35,21 @@ class LowPtGsfElectronIDProducer final : public edm::global::EDProducer<> {
static void fillDescriptions(edm::ConfigurationDescriptions&);

private:
double eval(const GBRForest& model, const reco::GsfElectron&, double rho, float unbiased, float field_z) const;
double eval(const GBRForest& model,
const reco::GsfElectron&,
double rho,
float unbiased,
float field_z,
const reco::Track* trk = nullptr) const;

template <typename EL, typename F>
void doWork(double rho, float bz, EL const& electrons, F&& idFunctor, edm::Event&) const;
template <typename EL, typename FID, typename FTRK>
void doWork(double rho, float bz, EL const& electrons, FID&& idFunctor, FTRK&& trkFunctor, edm::Event&) const;
const bool useGsfToTrack_;
const bool usePAT_;
edm::EDGetTokenT<reco::GsfElectronCollection> electrons_;
edm::EDGetTokenT<pat::ElectronCollection> patElectrons_;
const edm::EDGetTokenT<double> rho_;
edm::EDGetTokenT<edm::Association<reco::TrackCollection>> gsf2trk_;
edm::EDGetTokenT<edm::ValueMap<float>> unbiased_;
const edm::ESGetToken<MagneticField, IdealMagneticFieldRecord> fieldToken_;

Expand All @@ -60,10 +68,12 @@ class LowPtGsfElectronIDProducer final : public edm::global::EDProducer<> {
////////////////////////////////////////////////////////////////////////////////
//
LowPtGsfElectronIDProducer::LowPtGsfElectronIDProducer(const edm::ParameterSet& conf)
: usePAT_(conf.getParameter<bool>("usePAT")),
: useGsfToTrack_(conf.getParameter<bool>("useGsfToTrack")),
usePAT_(conf.getParameter<bool>("usePAT")),
electrons_(),
patElectrons_(),
rho_(consumes<double>(conf.getParameter<edm::InputTag>("rho"))),
gsf2trk_(),
unbiased_(),
fieldToken_(esConsumes()),
names_(conf.getParameter<std::vector<std::string>>("ModelNames")),
Expand All @@ -72,6 +82,9 @@ LowPtGsfElectronIDProducer::LowPtGsfElectronIDProducer(const edm::ParameterSet&
maxPtThreshold_(conf.getParameter<double>("MaxPtThreshold")),
thresholds_(conf.getParameter<std::vector<double>>("ModelThresholds")),
versionName_(conf.getParameter<std::string>("Version")) {
if (useGsfToTrack_) {
gsf2trk_ = consumes<edm::Association<reco::TrackCollection>>(conf.getParameter<edm::InputTag>("gsfToTrack"));
}
if (usePAT_) {
patElectrons_ = consumes<pat::ElectronCollection>(conf.getParameter<edm::InputTag>("electrons"));
} else {
Expand Down Expand Up @@ -117,6 +130,12 @@ void LowPtGsfElectronIDProducer::produce(edm::StreamID, edm::Event& event, const
throw cms::Exception("InvalidHandle", os.str());
}

// Retrieve GsfToTrack Association from Event
edm::Handle<edm::Association<reco::TrackCollection>> gsf2trk;
if (useGsfToTrack_) {
event.getByToken(gsf2trk_, gsf2trk);
}

double rho = *hRho;
// Retrieve pat::Electrons or reco::GsfElectrons from Event
edm::Handle<pat::ElectronCollection> patElectrons;
Expand All @@ -135,6 +154,28 @@ void LowPtGsfElectronIDProducer::produce(edm::StreamID, edm::Event& event, const
}
return ele.electronID(kUnbiased);
},
[&](auto const& ele) { // trkFunctor ...
if (useGsfToTrack_) {
using PackedPtr = edm::Ptr<pat::PackedCandidate>;
const PackedPtr* ptr1 = ele.template userData<PackedPtr>("ele2packed");
const PackedPtr* ptr2 = ele.template userData<PackedPtr>("ele2lost");
auto hasBestTrack = [](const PackedPtr* ptr) {
return ptr != nullptr && ptr->isNonnull() && ptr->isAvailable() && ptr->get() != nullptr &&
ptr->get()->bestTrack() != nullptr;
};
if (hasBestTrack(ptr1)) {
return ptr1->get()->bestTrack();
} else if (hasBestTrack(ptr2)) {
return ptr2->get()->bestTrack();
}
} else {
reco::TrackRef ref = ele.closestCtfTrackRef();
if (ref.isNonnull() && ref.isAvailable()) {
return ref.get();
}
}
return static_cast<const reco::Track*>(nullptr);
},
event);
} else {
auto const& electrons = event.getHandle(electrons_);
Expand All @@ -154,25 +195,45 @@ void LowPtGsfElectronIDProducer::produce(edm::StreamID, edm::Event& event, const
}
return unbiasedH[gsf];
},
[&](auto const& ele) { // trkFunctor ...
if (useGsfToTrack_) {
const auto& gsf = ele.core()->gsfTrack();
if (gsf.isNonnull() && gsf.isAvailable()) {
auto const& ref = (*gsf2trk)[gsf];
if (ref.isNonnull() && ref.isAvailable()) {
return ref.get();
}
}
} else {
reco::TrackRef ref = ele.closestCtfTrackRef();
if (ref.isNonnull() && ref.isAvailable()) {
return ref.get();
}
}
return static_cast<const reco::Track*>(nullptr);
},
event);
}
}

template <typename EL, typename F>
template <typename EL, typename FID, typename FTRK>
void LowPtGsfElectronIDProducer::doWork(
double rho, float bz, EL const& electrons, F&& idFunctor, edm::Event& event) const {
double rho, float bz, EL const& electrons, FID&& idFunctor, FTRK&& trkFunctor, edm::Event& event) const {
auto nElectrons = electrons->size();
std::vector<float> ids;
ids.reserve(nElectrons);
std::transform(electrons->begin(), electrons->end(), std::back_inserter(ids), idFunctor);
std::vector<const reco::Track*> trks;
trks.reserve(nElectrons);
std::transform(electrons->begin(), electrons->end(), std::back_inserter(trks), trkFunctor);

std::vector<float> output(nElectrons); //resused for each model
for (unsigned int index = 0; index < names_.size(); ++index) {
// Iterate through Electrons, evaluate BDT, and store result
for (unsigned int iele = 0; iele < nElectrons; iele++) {
auto const& ele = (*electrons)[iele];
if (ids[iele] != std::numeric_limits<float>::max()) {
output[iele] = eval(*models_[index], ele, rho, ids[iele], bz);
output[iele] = eval(*models_[index], ele, rho, ids[iele], bz, trks[iele]);
} else {
output[iele] = -999.;
}
Expand All @@ -187,13 +248,17 @@ void LowPtGsfElectronIDProducer::doWork(

//////////////////////////////////////////////////////////////////////////////////////////
//
double LowPtGsfElectronIDProducer::eval(
const GBRForest& model, const reco::GsfElectron& ele, double rho, float unbiased, float field_z) const {
double LowPtGsfElectronIDProducer::eval(const GBRForest& model,
const reco::GsfElectron& ele,
double rho,
float unbiased,
float field_z,
const reco::Track* trk) const {
std::vector<float> inputs;
if (version_ == Version::V0) {
inputs = lowptgsfeleid::features_V0(ele, rho, unbiased);
} else if (version_ == Version::V1) {
inputs = lowptgsfeleid::features_V1(ele, rho, unbiased, field_z);
inputs = lowptgsfeleid::features_V1(ele, rho, unbiased, field_z, trk);
}
return model.GetResponse(inputs.data());
}
Expand All @@ -202,8 +267,10 @@ double LowPtGsfElectronIDProducer::eval(
//
void LowPtGsfElectronIDProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;
desc.add<bool>("useGsfToTrack", false);
desc.add<bool>("usePAT", false);
desc.add<edm::InputTag>("electrons", edm::InputTag("lowPtGsfElectrons"));
desc.addOptional<edm::InputTag>("gsfToTrack", edm::InputTag("lowPtGsfToTrackLinks"));
desc.addOptional<edm::InputTag>("unbiased", edm::InputTag("lowPtGsfElectronSeedValueMaps:unbiased"));
desc.add<edm::InputTag>("rho", edm::InputTag("fixedGridRhoFastjetAll"));
desc.add<std::vector<std::string>>("ModelNames", {""});
Expand Down
3 changes: 0 additions & 3 deletions RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectronCores_cff.py
View file
Open in desktop
@@ -1,6 +1,3 @@
import FWCore.ParameterSet.Config as cms

from RecoEgamma.EgammaElectronProducers.lowPtGsfElectronCores_cfi import lowPtGsfElectronCores

from Configuration.Eras.Modifier_fastSim_cff import fastSim
fastSim.toModify(lowPtGsfElectronCores,ctfTracks = "generalTracksBeforeMixing")
8 changes: 8 additions & 0 deletions RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectronID_cfi.py
View file
Open in desktop
Expand Up @@ -8,3 +8,11 @@
lowPtGsfElectronID,
ModelWeights = ["RecoEgamma/ElectronIdentification/data/LowPtElectrons/LowPtElectrons_ID_2021May17.root"],
)

from Configuration.Eras.Modifier_fastSim_cff import fastSim
from Configuration.ProcessModifiers.run2_miniAOD_UL_cff import run2_miniAOD_UL
from PhysicsTools.NanoAOD.nano_eras_cff import *
(fastSim & (run2_miniAOD_UL | run2_nanoAOD_106Xv2)).toModify(
lowPtGsfElectronID,
useGsfToTrack = True,
)
3 changes: 0 additions & 3 deletions RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectronsPreRegression_cfi.py
View file
Open in desktop
@@ -1,6 +1,3 @@
from RecoEgamma.EgammaElectronProducers.gsfElectrons_cfi import ecalDrivenGsfElectrons

lowPtGsfElectronsPreRegression = ecalDrivenGsfElectrons.clone(gsfElectronCoresTag = "lowPtGsfElectronCores")

from Configuration.Eras.Modifier_fastSim_cff import fastSim
fastSim.toModify(lowPtGsfElectronsPreRegression,ctfTracksTag = "generalTracksBeforeMixing")
21 changes: 8 additions & 13 deletions RecoEgamma/EgammaElectronProducers/src/LowPtGsfElectronFeatures.cc
View file
Open in desktop
Expand Up @@ -132,7 +132,8 @@ namespace lowptgsfeleseed {

namespace lowptgsfeleid {

std::vector<float> features_V1(reco::GsfElectron const& ele, float rho, float unbiased, float field_z) {
std::vector<float> features_V1(
reco::GsfElectron const& ele, float rho, float unbiased, float field_z, const reco::Track* trk) {
float eid_rho = -999.;
float eid_sc_eta = -999.;
float eid_shape_full5x5_r9 = -999.;
Expand Down Expand Up @@ -168,18 +169,12 @@ namespace lowptgsfeleid {
float sc_clus2_E_ov_p = -999.;

// KF tracks
if (ele.core().isNonnull()) {
reco::TrackRef trk = ele.closestCtfTrackRef();
if (trk.isNonnull()) {
eid_trk_p = (float)trk->p();
eid_trk_nhits = (float)trk->found();
eid_trk_chi2red = (float)trk->normalizedChi2();
TVector3 trkTV3(0, 0, 0);
trkTV3.SetPtEtaPhi(trk->pt(), trk->eta(), trk->phi());
TVector3 eleTV3(0, 0, 0);
eleTV3.SetPtEtaPhi(ele.pt(), ele.eta(), ele.phi());
trk_dr = eleTV3.DeltaR(trkTV3);
}
if (trk != nullptr || (ele.core().isNonnull() && ele.closestCtfTrackRef().isNonnull())) {
const reco::Track* tk = trk ? trk : &*ele.closestCtfTrackRef();
eid_trk_p = tk->p();
eid_trk_nhits = tk->found();
eid_trk_chi2red = tk->normalizedChi2();
trk_dr = reco::deltaR(*tk, ele);
}

// GSF tracks
Expand Down