Added esConsumes calls to code in RecoLocalMuon

[Dr15Jones]

PR description:

• had to propagate ConsumesCollector to many helpers/plugins
• required some work outside of RecoLocalMuon to allow code to compile

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35184/25121

• This PR adds an extra 152KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• CalibMuon/DTCalibration (alca)
• CalibMuon/DTDigiSync (alca)
• DQM/DTMonitorModule (dqm)
• L1Trigger/DTTriggerPhase2 (upgrade, l1)
• RecoLocalMuon/DTRecHit (reconstruction)
• RecoLocalMuon/DTSegment (reconstruction)

@malbouis, @andrius-k, @yuanchao, @rekovic, @kmaeshima, @ErnestaP, @ahmad3213, @rvenditti, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @slava77, @jpata, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @bellan, @tocheng, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[tvami]

FYI @swagata87

[tvami]

Please remove commented out code + get rid of std::cout

[tvami]

Maybe time to make it const as the comment suggests?

[Dr15Jones]

Neither std::unique_ptr<DTTTrigBaseSync const> theSync; nor const std::unique_ptr<DTTTrigBaseSync> theSync; compile. So it is unclear what that legacy comment wants.

[swagata87]

FYI @swagata87

Hi @tvami , thanks!
So I also started esConsumes migration of CalibMuon/DTCalibration as asked by Yuan from AlCa. And later I had plans to do the same for CalibMuon/DTDigiSync. These are the two packages that I'm responsible for, as DT calibration contact. Do I understand correctly that this PR already does the esConsumes migration for both these packages? If that is the case, then it's great, and there is not much to do from DT calibration side anymore. I can propagate the information to DT DPG.

[Dr15Jones]

ping @cms-sw/l1-l2

[jpata]

+reconstruction

• for c87cf4b, looking at changes in the RecoLocalMuon files
• technical, no reco differences observed (the tests caught something in cosmics earlier which was fixed)

[srimanob]

+Upgrade

For the upgrade part, the change is in L1Trigger/DTTriggerPhase2 which is technical change. No change is expected.

[tvami]

@rekovic @cecilecaillol @lathomas would you please sign this?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1