/validation/RecoEgamma PHASE2 modifications

[archiron]

PR description:

Following a precedent PR (34439) we made a small correction in order to correct a little bug affecting this PR and the releases validations, where the barrel electrons are gone.
This can be seen on the picture below :

With our corrections the bug is corrected (see below) and we also added some corrections on the RECO/Fake contributions in order to enhance the PHASE2 endcaps representation.
Those corrections also correct the pbm such as in PoPtrueVsEta_pfx as we can see :

without corrections	with corrections

PR validation:

compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine (39 38 37 28 18 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed).
here is the run-log :

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch -> OK.
• verify that changes follow CMS Naming, Coding, And Style Rules -> OK.
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions -> OK.

@beaudett
@SohamBhattacharya

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25128

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @archiron (Chiron) for master.

It involves the following packages:

• Validation/RecoEgamma (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee01f0/18406/summary.html
COMMIT: ae5bf79
CMSSW: CMSSW_12_1_X_2021-09-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35192/18406/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25133

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #35192 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25220

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #35192 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[perrotta]

At this point. deltaR_ is not needed any more as class member, and it can be removed from them

[archiron]

OK, deltaR_ is removed. Please note that we have planned a PR during november/december in order to do such a modifications.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25226

• This PR adds an extra 60KB to repository

[cmsbuild]

Pull request #35192 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee01f0/18552/summary.html
COMMIT: 006bbae
CMSSW: CMSSW_12_1_X_2021-09-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35192/18552/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000833
• DQMHistoTests: Total failures: 1378
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999433
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -44.289 KiB( 38 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -1.066 KiB EgammaV/ElectronMcSignalValidatorPt1000
• DQMHistoSizes: changed ( 10024.0,... ): -1.043 KiB EgammaV/ElectronMcSignalValidator
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1