Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[10_6_X] Have embedded root files send close reports" #35214

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 9, 2021

Reverts #35180 ASAN pointed out problems with the PR in master, see #34873 (comment) for more details.

Sorry for the trouble, should have checked things more carefully in master first.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_10_6_X.

It involves the following packages:

  • IOPool/Input (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Sep 9, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2f19/18452/summary.html
COMMIT: 5259cd1
CMSSW: CMSSW_10_6_X_2021-09-07-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35214/18452/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

makortel commented Sep 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 9, 2021

+1

@cmsbuild cmsbuild merged commit ad9d448 into cms-sw:CMSSW_10_6_X Sep 9, 2021
@makortel makortel deleted the revert-35180-embeddedSenderService_106x branch September 9, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants