New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MultiTrackValidator] Fix #35225 #35319
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35319/25358
|
A new Pull Request was created by @lecriste (Leonardo Cristella) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35319/25360
|
Pull request #35319 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35319/25365
|
Pull request #35319 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bac38/18752/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Could the title of the PR be changed to something more self explanatory (e.g. mention at least MultiTrackValidator)? It would help with the release validation procedure |
+1 |
PR description:
This PR fixes a bug introduced with #34954: in case of an empty
PlotterFolder
, the return value of theSimpleValidation._doPlots
function was different and caused the raise of an Exception.The warning for a missing object in the
PlotterFolder
is now always printed (not only with theverbose
option).PR validation:
makeHGCalValidationPlots.py
andmakeTrackValidationPlots.py