Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1Trigger/CSCTriggerPrimitives documentation #35325

Merged
merged 1 commit into from Sep 27, 2021
Merged

Update L1Trigger/CSCTriggerPrimitives documentation #35325

merged 1 commit into from Sep 27, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Sep 17, 2021

PR description:

The README file is outdated. Relevant information is now contained in a note for Run-3 and Phase-2 DN-21-019.

PR validation:

N/A

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

@tahuang1991

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35325/25366

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

  • L1Trigger/CSCTriggerPrimitives (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Sep 19, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68d4fe/18734/summary.html
COMMIT: a57d862
CMSSW: CMSSW_12_1_X_2021-09-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35325/18734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211058
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@dildick
Copy link
Contributor Author

dildick commented Sep 22, 2021

@rekovic This PR is a trivial update of the documentation. See https://gitlab.cern.ch/tdr/notes/DN-21-019/blob/master/temp/DN-21-019_temp.pdf for details

@qliphy
Copy link
Contributor

qliphy commented Sep 27, 2021

merge
trivial update on documentation

@cmsbuild cmsbuild merged commit c1cb2f1 into cms-sw:master Sep 27, 2021
@dildick dildick deleted the patch-1 branch September 27, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants