New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add genfragment for Chi_b -> Y(1S)Gamma and Chi_c -> J/psiGamma #35330
Conversation
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35330/25376
|
A new Pull Request was created by @mtosi (mia tosi) for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08618c/18729/summary.html Comparison SummarySummary:
|
@cms-sw/generators-l2 Any comment? |
No issues for me. I worked in those cfg couple of years ago, and should be ok. |
As @alberto-sanchez used them already, I have no comments on the physics. Maybe two small ones on the names. |
I have run again these cfgs. I found an issue with the one for chic. The 'PhaseSpace:pTHatMin = 2.' seems low. I would suggest to set it to something like 'PhaseSpace:pTHatMin = 10.' this is because the cut on the J/psi is higher (16.0 GeV), which is well motivated for the high pT thresholds on the triggers for inclusive J/psi. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35330/26216
|
Pull request #35330 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again. |
please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ... |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08618c/20128/summary.html Comparison SummarySummary:
|
All comments are addressed. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
following the suggestion and request by BPH PAG,
we are adding the genFragments for the Chi_b --> Y(1S)Gamma and Chi_c --> J/psiGamma production at 14 TeV
these will be used for the special relval samples request we are aiming for the validation of the effect of the loopers disabling (https://its.cern.ch/jira/browse/PDMVRELVALS-128) and the mkFit (https://its.cern.ch/jira/browse/PDMVRELVALS-130)
@kskovpen @slezki