New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esConsumes migration of CalibMuon/DTCalibration #35336
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35336/25388
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35336/25389
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5939a2/18743/summary.html CMS StaticAnalyzer warnings: There are 11 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5939a2/18743/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
Hi @swagata87 the SA shows these errors of the EDAnalyzers needed to be a |
Hi @tvami, |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR aims to partially migrate
CalibMuon/DTCalibration
package to use esConsumes. Technical PR, no change in physics is expected.PR validation:
code compiles.
runTheMatrix.py -l 1330
ran fineThis PR is not a backport.
Backport not needed.