New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make pileup-JME default for top projection in PFBRECO sequence #3535
make pileup-JME default for top projection in PFBRECO sequence #3535
Conversation
A new Pull Request was created by @monttj (Tae Jeong Kim) for CMSSW_7_1_X. make pileup-JME default for top projection in PFBRECO sequence It involves the following packages: CommonTools/ParticleFlow @nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks. |
make JME way to identify pileup default by turning off following option in default sequence
|
@monttj I don't think this is sufficient. If you load
and backtrack how
are produced you will see that they still come from the 'JME' instance of pfNoPU. |
okay, it has been changed all downstream of PFBRECO. |
+1 |
Hi Taejeong Should I expect any changes in RECO objects or in the DQM plots? |
@slava77 This PR can be closed. This was an attempt to modify some PFBRECO modules so that example PAT config files stay backward compatible. But as Taejeong pointed out, PFBRECO sequence is now also used in the standard reconstruction so it is easier to just update the PAT config files which was done in #3510 |
-1 Hi Dinko, Thanks for the comment. |
Hi Slava, Sorry for being late. It does not affect the reco with changes as reco uses "JME" which this issue was trying to make as default without postfix. Taejeong |
Hi Taejeong, I'm confused. Please clarify. |
Hi Slava, I tried to provide more details in addition to the comments from Dinko. Taejeong |
No description provided.