Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBSAN] Added missing deps in CalibTracker/SiStripCommon #35364

Merged
merged 1 commit into from Sep 22, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Sep 22, 2021

UBSAN IBs failed to build with error

SiStripOnTrackClusterTableProducerBase.cc.o:(.data.rel+0x498): undefined reference to `typeinfo for BasicTrajectoryState'

This adds the missing deps on TrackingTools/PatternTools used here https://github.com/cms-sw/cmssw/blob/master/CalibTracker/SiStripCommon/interface/SiStripOnTrackClusterTableProducerBase.h#L8 added by #34985

@smuzaffar smuzaffar changed the title Added missing deps in CalibTracker/SiStripCommon [UBSAN] Added missing deps in CalibTracker/SiStripCommon Sep 22, 2021
@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Sep 22, 2021
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35364/25442

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CalibTracker/SiStripCommon (alca)

@yuanchao, @malbouis, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fb10a/18815/summary.html
COMMIT: 3a2a9b5
CMSSW: CMSSW_12_1_X_2021-09-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35364/18815/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211058
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • techincal
  • all tests passed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 22, 2021

+1

@cmsbuild cmsbuild merged commit 6d0682a into cms-sw:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants