PPS: Run3 alignment fix for direct simulation

[jan-kaspar]

PR description:

This PR intends mostly to correct for an undesired effect of #35380 (and erratum #35399) on the "direct" simulation of forward protons in PPS, in the Run3 profiles.

Technically, this PR includes the following changes.

• The "master" geometry config Geometry/VeryForwardGeometry/python/geometryRPFromDD_2021_cfi.py now loads the latest versioned config (introduced in Fixes for PPS geometry on Pixel sensors and materials #35380). This makes the changes from Fixes for PPS geometry on Pixel sensors and materials #35380 effective to PPS direct simulation and other PPS applications: in particularly moving the pixel sensors closer to the beam by ~750 um in Run3 scenarios.
• Geometry configs for 2022 created - to avoid confusion, content as for 2021.
• Direct simulation Run3 scenarios updated: alignment changed to compensate the move of pixel sensors mentioned in the first bullet.

For Run2, no changes in results are expected.

No backport is foreseen.

PR validation:

Below a summary plot from Run3 scenarios of the direct simulation. Blue = before this PR. Green = with this PR, but only after "activation" of the changes from #35380. Red dashed = at the end of this PR, i.e. including the compensation shift. Especially the x histograms show the shifts of the RP acceptance closer to and further from the LHC beam (x = 0). The compensation shift (blue - red comparison) is not perfect, but good enough (the RP approach to the beam is just a forecast anyway).
dirsim_cmp_Run3.pdf

For Run2, the plots below compare the results before this PR (blue, covered with green) and after this PR (red dashed)

• dirsim_cmp_Run2.pdf - no change as expected
• reco_cmp.pdf - no changes as expected

@fabferro @diemort @grzanka FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35424/25549

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

• Geometry/VeryForwardGeometry (geometry)
• Validation/CTPPS (dqm)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@bsunanda, @fabferro, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f40c08/18942/summary.html
COMMIT: 51b5265
CMSSW: CMSSW_12_1_X_2021-09-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35424/18942/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1299 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 3671
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 3207368
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.703 KiB( 39 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[civanch]

Regression difference in 140.53 is not connected with this PR.
In this PR "2022" variant of geometry is created. This is natural for PPS but needs to be discussed.

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

Regression difference in 140.53 is not connected with this PR. In this PR "2022" variant of geometry is created. This is natural for PPS but needs to be discussed.

About 2022 geometry, do you prefer to remove it for now or keep as it is in this PR ? @civanch

[civanch]

@qliphy , @perrotta , I think we can merge this PR. Having 2022 geometry does not contradict to our policy today.

[qliphy]

+1