check CMS_OPENLOOPS_PREFIX env variable before using it

[smuzaffar]

Workflow 573.0 for ppc64le IBs fails with error

  File "Configuration/Generator/sherpa_ttbar_2j_MENLOPS_13TeV_MASTER_ExtGen_cff.py", line 32, in <module>
    " OL_PREFIX={0} ".format(os.environ['CMS_OPENLOOPS_PREFIX']),
  File "python3/3.9.6/lib/python3.9/os.py", line 679, in __getitem__
    raise KeyError(key) from None
KeyError: 'CMS_OPENLOOPS_PREFIX'

this is because for ppc64le openloops is not build and env CMS_OPENLOOPS_PREFIX is not available.

The PR checks the variable before using it. Workflow 573 is still going to fail with error

Matrix_Element_Handler::BuildProcesses(): Looking for processes ME_Generators::LoadGenerator(): Try loading 'OpenLoops' from 'libSherpaOpenLoops'.
Library_Loader::LoadLibrary(): Failed to load library 'libSherpaOpenLoops.so'.
ME_Generators::LoadGenerator(): ME generator 'OpenLoops' not found. Ignoring it.
Library_Loader::LoadLibrary(): 573.0_sherpa_ttbar_2j_MENLOPS_13TeV_MASTER_ExtGen+sherpa_ttbar_2j_MENLOPS_13TeV_MASTER_ExtGen+HARVESTGEN/thread124242_0/Process/Amegic/lib/libProc_P2_2.so: cannot open shared object file: No such file or directory
Library_Loader::LoadLibrary(): Failed to load library 'libProc_P2_2.so'.

as the library libProc_P2_2.so ( bundled in gridpacks) is built for x86_64 and not going to work on ppc64le and aarch64

[smuzaffar]

@cms-sw/generators-l2 , aren't we missing a ; here? Should not it be

" OL_PREFIX={0};".format(....)

[SiewYan]

Hello @smuzaffar , thanks for catching it. Could you please add the ;? Thanks!!

[smuzaffar]

done

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35425/25550

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Configuration/Generator (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c988d9/18947/summary.html
COMMIT: c5313cc
CMSSW: CMSSW_12_1_X_2021-09-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35425/18947/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[agrohsje]

+generators

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@agrohsje did you notice the question from @smuzaffar? And what is the answer?

[SiewYan]

Hello @perrotta , yes , the semi-colon is missing. But its look like it pass the test without ;. For consistency, one should add ;

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35425/25580

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #35425 was updated. @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[agrohsje]

+generators
Thanks @perrotta for the heads-up. I misunderstood the question. My mistake. Thanks @smuzaffar for adding.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c988d9/19171/summary.html
COMMIT: d57ea91
CMSSW: CMSSW_12_1_X_2021-09-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35425/19171/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[perrotta]

+1