New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParameterizedSubtractor now calls base class implmentation #35431
Conversation
The code previous was a cut-n-paste of the base class with some minor additions. Since the base class was updated to use esConsumes it is better to just call that implementation.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35431/25562
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-228efc/19149/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The code previous was a cut-n-paste of the base class with some minor additions. Since the base class was updated to use esConsumes it is better to just call that implementation.
PR validation:
Code compiles.