Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run3-alca204Z Change defaults for AlCaIsoTrackFilter and AlCaHBHEMuonFilter for test runs #35458

Merged
merged 2 commits into from Sep 30, 2021
Merged

Run3-alca204Z Change defaults for AlCaIsoTrackFilter and AlCaHBHEMuonFilter for test runs #35458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6efc691
Change defaults for AlCaIsoTrackFilter and AlCaHBHEMuonFilter for tes…
Sep 28, 2021
6bcd24c
Take care of comments
Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
119 changes: 66 additions & 53 deletions Calibration/HcalAlCaRecoProducers/plugins/AlCaHBHEMuonFilter.cc
View file
Open in desktop
Expand Up @@ -112,9 +112,11 @@ AlCaHBHEMuonFilter::AlCaHBHEMuonFilter(edm::ParameterSet const& iConfig, const A
tok_geom_ = esConsumes<CaloGeometry, CaloGeometryRecord>();
tok_magField_ = esConsumes<MagneticField, IdealMagneticFieldRecord>();

edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \n"
<< "Process " << processName_ << " Prescale " << preScale_ << " Isolation Cuts "
<< trackIsoCut_ << ":" << caloIsoCut_ << "\n";
edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \nProcess " << processName_ << " Prescale "
<< preScale_ << " Isolation Cuts " << pfCut_ << ":" << pfIsoCut_ << ":" << trackIsoCut_
<< ":" << caloIsoCut_ << "\nInput tags "
<< labelMuon_ << " and " << triggerResults_ << "\nStudy " << trigNames_.size()
<< " triggers: ";
for (unsigned int k = 0; k < trigNames_.size(); ++k)
edm::LogVerbatim("HBHEMuon") << "Trigger[" << k << "] " << trigNames_[k] << "\n";
} // AlCaHBHEMuonFilter::AlCaHBHEMuonFilter constructor
Expand All @@ -135,68 +137,79 @@ bool AlCaHBHEMuonFilter::filter(edm::Event& iEvent, edm::EventSetup const& iSetu
<< std::endl;
#endif
//Step1: Find if the event passes one of the chosen triggers
bool ok(false);
/////////////////////////////TriggerResults
edm::Handle<edm::TriggerResults> triggerResults;
iEvent.getByToken(tok_trigRes_, triggerResults);
if (triggerResults.isValid()) {
bool ok(false);
std::vector<std::string> modules;
const edm::TriggerNames& triggerNames = iEvent.triggerNames(*triggerResults);
const std::vector<std::string>& triggerNames_ = triggerNames.triggerNames();
for (unsigned int iHLT = 0; iHLT < triggerResults->size(); iHLT++) {
int hlt = triggerResults->accept(iHLT);
for (unsigned int i = 0; i < trigNames_.size(); ++i) {
if (triggerNames_[iHLT].find(trigNames_[i]) != std::string::npos) {
if (hlt > 0) {
ok = true;
}
if (trigNames_.empty()) {
ok = true;
} else {
edm::Handle<edm::TriggerResults> triggerResults;
iEvent.getByToken(tok_trigRes_, triggerResults);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preferred method is with the getHandle

if (triggerResults.isValid()) {
std::vector<std::string> modules;
const edm::TriggerNames& triggerNames = iEvent.triggerNames(*triggerResults);
const std::vector<std::string>& triggerNames_ = triggerNames.triggerNames();
for (unsigned int iHLT = 0; iHLT < triggerResults->size(); iHLT++) {
int hlt = triggerResults->accept(iHLT);
for (unsigned int i = 0; i < trigNames_.size(); ++i) {
if (triggerNames_[iHLT].find(trigNames_[i]) != std::string::npos) {
if (hlt > 0) {
ok = true;
}
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Trigger " << triggerNames_[iHLT] << " Flag " << hlt
<< ":" << ok << std::endl;
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Trigger " << triggerNames_[iHLT] << " Flag " << hlt
<< ":" << ok << std::endl;
#endif
}
}
}
}
if (ok) {
//Step2: Get geometry/B-field information
const MagneticField* bField = &(iSetup.getData(tok_magField_));
const CaloGeometry* geo = &(iSetup.getData(tok_geom_));

// Relevant blocks from iEvent
edm::Handle<reco::MuonCollection> _Muon;
iEvent.getByToken(tok_Muon_, _Muon);
}
if (ok) {
//Step2: Get geometry/B-field information
const MagneticField* bField = &(iSetup.getData(tok_magField_));
const CaloGeometry* geo = &(iSetup.getData(tok_geom_));

// Relevant blocks from iEvent
edm::Handle<reco::MuonCollection> _Muon;
iEvent.getByToken(tok_Muon_, _Muon);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, please use getHandle instead

#ifdef EDM_ML_DEBUG
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Muon Handle " << _Muon.isValid() << std::endl;
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Muon Handle " << _Muon.isValid();
#endif
if (_Muon.isValid()) {
for (reco::MuonCollection::const_iterator RecMuon = _Muon->begin(); RecMuon != _Muon->end(); ++RecMuon) {
if (_Muon.isValid()) {
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Muon:Track " << RecMuon->track().isNonnull()
<< " innerTrack " << RecMuon->innerTrack().isNonnull() << " outerTrack "
<< RecMuon->outerTrack().isNonnull() << " globalTrack "
<< RecMuon->globalTrack().isNonnull() << std::endl;
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Size of collection " << _Muon->size();
#endif
if ((RecMuon->track().isNonnull()) && (RecMuon->innerTrack().isNonnull()) &&
(RecMuon->outerTrack().isNonnull()) && (RecMuon->globalTrack().isNonnull())) {
const reco::Track* pTrack = (RecMuon->innerTrack()).get();
spr::propagatedTrackID trackID = spr::propagateCALO(pTrack, geo, bField, false);
for (reco::MuonCollection::const_iterator RecMuon = _Muon->begin(); RecMuon != _Muon->end(); ++RecMuon) {
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Propagate: ECAL " << trackID.okECAL << " to HCAL "
<< trackID.okHCAL << std::endl;
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Muon:Track " << RecMuon->track().isNonnull()
<< " innerTrack " << RecMuon->innerTrack().isNonnull() << " outerTrack "
<< RecMuon->outerTrack().isNonnull() << " globalTrack "
<< RecMuon->globalTrack().isNonnull() << std::endl;
#endif
double trackIso = RecMuon->isolationR03().sumPt;
double caloIso = RecMuon->isolationR03().emEt + RecMuon->isolationR03().hadEt;
double isolR04 =
((RecMuon->pfIsolationR04().sumChargedHadronPt +
std::max(0.,
RecMuon->pfIsolationR04().sumNeutralHadronEt + RecMuon->pfIsolationR04().sumPhotonEt -
(0.5 * RecMuon->pfIsolationR04().sumPUPt))) /
RecMuon->pt());
bool isoCut = (pfCut_) ? (isolR04 < pfIsoCut_) : ((trackIso < trackIsoCut_) && (caloIso < caloIsoCut_));
if ((trackID.okECAL) && (trackID.okHCAL) && isoCut) {
accept = true;
break;
}
if ((RecMuon->track().isNonnull()) && (RecMuon->innerTrack().isNonnull()) &&
(RecMuon->outerTrack().isNonnull()) && (RecMuon->globalTrack().isNonnull())) {
const reco::Track* pTrack = (RecMuon->innerTrack()).get();
spr::propagatedTrackID trackID = spr::propagateCALO(pTrack, geo, bField, false);
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Propagate: ECAL " << trackID.okECAL << " to HCAL "
<< trackID.okHCAL << std::endl;
#endif
double trackIso = RecMuon->isolationR03().sumPt;
double caloIso = RecMuon->isolationR03().emEt + RecMuon->isolationR03().hadEt;
double isolR04 =
((RecMuon->pfIsolationR04().sumChargedHadronPt +
std::max(0.,
RecMuon->pfIsolationR04().sumNeutralHadronEt + RecMuon->pfIsolationR04().sumPhotonEt -
(0.5 * RecMuon->pfIsolationR04().sumPUPt))) /
RecMuon->pt());
bool isoCut = (pfCut_) ? (isolR04 < pfIsoCut_) : ((trackIso < trackIsoCut_) && (caloIso < caloIsoCut_));
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("HBHEMuon") << "AlCaHBHEMuonFilter::Isolation: " << trackIso << ":" << caloIso << ":"
<< isolR04 << " --> " << isoCut;
#endif
if ((trackID.okECAL) && (trackID.okHCAL) && isoCut) {
accept = true;
break;
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions Calibration/HcalAlCaRecoProducers/python/alcaHBHEMuonFilter_cfi.py
View file
Open in desktop
Expand Up @@ -5,10 +5,10 @@
TriggerResultLabel= cms.InputTag("TriggerResults","","HLT"),
MuonLabel = cms.InputTag("muons"),
MinimumMuonP = cms.double(10.0),
Triggers = cms.vstring("HLT_IsoMu","HLT_Mu"),
Triggers = cms.vstring(),
PFCut = cms.bool(True),
PFIsolationCut = cms.double(0.12),
TrackIsolationCut = cms.double(3.0),
CaloIsolationCut = cms.double(5.0),
PreScale = cms.int32(2),
PreScale = cms.int32(1),
)
2 changes: 1 addition & 1 deletion Calibration/HcalAlCaRecoProducers/src/AlCaIsoTracksProducer.cc
View file
Open in desktop
Expand Up @@ -286,7 +286,7 @@ void AlCaIsoTracksProducer::fillDescriptions(edm::ConfigurationDescriptions& des
// Prescale events only containing isolated tracks in the range
desc.add<double>("momentumRangeLow", 20.0);
desc.add<double>("momentumRangeHigh", 40.0);
desc.add<int>("preScaleFactor", 10);
desc.add<int>("preScaleFactor", 1);
descriptions.add("alcaisotrk", desc);
}

Expand Down